HomePhabricator

Allow menu items to be edited again

Authored by epriestley on Jan 31 2017, 9:23 PM.

Description

Allow menu items to be edited again

Summary:
Ref T12174. We now require that we can figure out a valid "edit mode" (global vs custom/personal) before we hit EditEngine. Since the EditEngine routes don't have an itemID, they would failu to figure out the mode and just 404.

Let the engine use id (from EditEngine) if itemID (from MenuEngine) isn't present in the route.

Test Plan:

  • Edited some menu items on Home / Projects.
  • (I think I tested this, then broke it, originally.)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12174

Differential Revision: https://secure.phabricator.com/D17280

Details

Committed
epriestleyJan 31 2017, 9:36 PM
Pushed
epriestleyJan 31 2017, 9:36 PM
Reviewer
chad
Differential Revision
D17280: Allow menu items to be edited again
Parents
rPf7c381358656: Add Label MenuItem
Branches
Unknown
Tags
Unknown
Tasks
T12174: Home Menu Errata
Build Status
Buildable 15468
Build 20385: Run Core Tests