Page MenuHomePhabricator

Restore "[Action]" mail subject lines to Differential/Diffusion
ClosedPublic

Authored by epriestley on Jan 12 2017, 3:47 PM.
Tags
None
Referenced Files
F13196652: D17191.diff
Sun, May 12, 11:27 PM
F13178665: D17191.diff
Wed, May 8, 8:34 PM
Unknown Object (File)
Tue, May 7, 1:18 AM
Unknown Object (File)
Thu, May 2, 8:51 AM
Unknown Object (File)
Sun, Apr 28, 4:55 PM
Unknown Object (File)
Sat, Apr 27, 8:06 AM
Unknown Object (File)
Thu, Apr 25, 3:16 PM
Unknown Object (File)
Fri, Apr 19, 6:04 PM
Subscribers
None

Details

Summary

Ref T11114. Ref T10978. These hadn't made it over to EditEngine yet.

Test Plan
  • Took various actions on revisions and commits.
  • Used bin/mail show-outbound --id ... to examine the "Vary Subject", saw it properly generate "[Accepted]", "[Resigned]", etc.

Diff Detail

Repository
rP Phabricator
Branch
commit13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15226
Build 20015: Run Core Tests
Build 20014: arc lint + arc unit

Event Timeline

I intentionally made some of these a little more concise ("Requested A Review Of" -> "Requested Review") since they were a little wordy/inconsistent.

This revision is now accepted and ready to land.Jan 12 2017, 4:29 PM
This revision was automatically updated to reflect the committed changes.