Page MenuHomePhabricator

Restore "[Action]" mail subject lines to Differential/Diffusion
ClosedPublic

Authored by epriestley on Jan 12 2017, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 2:42 AM
Unknown Object (File)
Sat, Mar 23, 2:42 AM
Unknown Object (File)
Wed, Mar 6, 5:50 AM
Unknown Object (File)
Feb 7 2024, 2:57 PM
Unknown Object (File)
Feb 3 2024, 1:57 PM
Unknown Object (File)
Feb 2 2024, 2:19 AM
Unknown Object (File)
Jan 28 2024, 12:29 AM
Unknown Object (File)
Jan 21 2024, 12:41 PM
Subscribers
None

Details

Summary

Ref T11114. Ref T10978. These hadn't made it over to EditEngine yet.

Test Plan
  • Took various actions on revisions and commits.
  • Used bin/mail show-outbound --id ... to examine the "Vary Subject", saw it properly generate "[Accepted]", "[Resigned]", etc.

Diff Detail

Repository
rP Phabricator
Branch
commit13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15226
Build 20015: Run Core Tests
Build 20014: arc lint + arc unit

Event Timeline

I intentionally made some of these a little more concise ("Requested A Review Of" -> "Requested Review") since they were a little wordy/inconsistent.

This revision is now accepted and ready to land.Jan 12 2017, 4:29 PM
This revision was automatically updated to reflect the committed changes.