Page MenuHomePhabricator
Differential D17191

Restore "[Action]" mail subject lines to Differential/Diffusion
ClosedPublic
Actions

Authored by epriestley on Jan 12 2017, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 3, 1:00 AM
Unknown Object (File)
Mon, Apr 1, 1:31 AM
Unknown Object (File)
Sat, Mar 30, 3:54 AM
Unknown Object (File)
Thu, Mar 28, 9:46 PM
Unknown Object (File)
Thu, Mar 28, 12:54 PM
Unknown Object (File)
Sat, Mar 23, 2:42 AM
Unknown Object (File)
Sat, Mar 23, 2:42 AM
Unknown Object (File)
Mar 6 2024, 5:50 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10978: Modernize Audit
T11114: Move Differential to EditEngine
Commits
rP7d3d0224071a: Restore "[Action]" mail subject lines to Differential/Diffusion
Summary

Ref T11114. Ref T10978. These hadn't made it over to EditEngine yet.

Test Plan
  • Took various actions on revisions and commits.
  • Used bin/mail show-outbound --id ... to examine the "Vary Subject", saw it properly generate "[Accepted]", "[Resigned]", etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 12 2017, 3:47 PM
Harbormaster completed remote builds in B15226: Diff 41338.Jan 12 2017, 3:48 PM
epriestley added a comment.Jan 12 2017, 3:57 PM

I intentionally made some of these a little more concise ("Requested A Review Of" -> "Requested Review") since they were a little wordy/inconsistent.

chad accepted this revision.Jan 12 2017, 4:29 PM
This revision is now accepted and ready to land.Jan 12 2017, 4:29 PM
Closed by commit rP7d3d0224071a: Restore "[Action]" mail subject lines to Differential/Diffusion (authored by epriestley, committed by epriestley). · Explain WhyJan 12 2017, 7:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41341

View Options

src/applications/differential/xaction/DifferentialRevisionAbandonTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionActionTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionRejectTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionResignTransaction.php

Loading...
View Options

src/applications/diffusion/xaction/DiffusionCommitAcceptTransaction.php

Loading...
View Options

src/applications/diffusion/xaction/DiffusionCommitConcernTransaction.php

Loading...
View Options

src/applications/diffusion/xaction/DiffusionCommitResignTransaction.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorModularTransaction.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorModularTransactionType.php

Loading...
Phabricator · Built by Phacility