Page MenuHomePhabricator

Restore "[Action]" mail subject lines to Differential/Diffusion
ClosedPublic

Authored by epriestley on Jan 12 2017, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 8:07 PM
Unknown Object (File)
Mon, Jan 27, 6:50 PM
Unknown Object (File)
Wed, Jan 22, 9:43 PM
Unknown Object (File)
Wed, Jan 22, 9:43 PM
Unknown Object (File)
Wed, Jan 22, 9:38 PM
Unknown Object (File)
Wed, Jan 22, 9:25 PM
Unknown Object (File)
Tue, Jan 21, 7:05 PM
Unknown Object (File)
Tue, Jan 21, 11:54 AM
Subscribers
None

Details

Summary

Ref T11114. Ref T10978. These hadn't made it over to EditEngine yet.

Test Plan
  • Took various actions on revisions and commits.
  • Used bin/mail show-outbound --id ... to examine the "Vary Subject", saw it properly generate "[Accepted]", "[Resigned]", etc.

Diff Detail

Repository
rP Phabricator
Branch
commit13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15226
Build 20015: Run Core Tests
Build 20014: arc lint + arc unit

Event Timeline

I intentionally made some of these a little more concise ("Requested A Review Of" -> "Requested Review") since they were a little wordy/inconsistent.

This revision is now accepted and ready to land.Jan 12 2017, 4:29 PM
This revision was automatically updated to reflect the committed changes.