Page MenuHomePhabricator
Differential D17183

Use EditEngine stacked comments in Diffusion
ClosedPublic
Actions

Authored by epriestley on Jan 11 2017, 10:27 PM.
Tags
None
Referenced Files
F15517603: D17183.id41325.diff
Sat, Apr 19, 7:07 AM
F15517602: D17183.id41323.diff
Sat, Apr 19, 7:06 AM
F15517599: D17183.id.diff
Sat, Apr 19, 7:04 AM
F15457654: D17183.diff
Sun, Mar 30, 5:33 PM
F15441440: D17183.diff
Wed, Mar 26, 6:15 PM
F15425943: D17183.id41323.diff
Mar 23 2025, 6:42 AM
F15425052: D17183.id.diff
Mar 23 2025, 2:14 AM
F15421235: D17183.diff
Mar 21 2025, 9:55 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8739: Inline comments not sorted
T10446: Unable to simply mark a Diffusion comment as Done
T10978: Modernize Audit
Commits
rPb5722a99635a: Use EditEngine stacked comments in Diffusion
Summary

Ref T10978. Ref T8739. Fixes T10446. Converts Diffusion to modern comment/preview code, like Differential.

Test Plan

Screen Shot 2017-01-11 at 2.22.49 PM.png (1×1 px, 233 KB)

Diff Detail

Repository
rP Phabricator
Branch
commit8
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/diff/view/PHUIDiffInlineCommentPreviewListView.php:41XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 15210
Build 19990: Run Core Tests
Build 19989: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
26 lines
1 line
src/
4 lines
applications/
audit/
application/
2 lines
controller/
editor/
17 lines
storage/
7 lines
view/
7 lines
differential/
controller/
7 lines
diffusion/
controller/
144 lines
editor/
87 lines
infrastructure/
diff/
view/
11 lines
webroot/
rsrc/
js/
application/
differential/
16 lines

Diff 41323

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/audit/application/PhabricatorAuditApplication.php

Loading...
View Options

src/applications/audit/controller/PhabricatorAuditAddCommentController.php

Loading...
View Options

src/applications/audit/controller/PhabricatorAuditPreviewController.php

Loading...
View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/audit/storage/PhabricatorAuditInlineComment.php

Loading...
View Options

src/applications/audit/view/PhabricatorAuditTransactionView.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentPreviewListView.php

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-keyboard-nav.js

Loading...
Phabricator · Built by Phacility