Page MenuHomePhabricator

Fix a bad interaction between "arc diff --reviewers" and "the first line of a message is always a title"
ClosedPublic

Authored by epriestley on Jan 5 2017, 10:00 PM.
Tags
None
Referenced Files
F15454608: D17147.id41236.diff
Sat, Mar 29, 7:19 PM
F15432268: D17147.id.diff
Mon, Mar 24, 5:09 PM
F15429433: D17147.diff
Mon, Mar 24, 2:15 AM
Unknown Object (File)
Feb 26 2025, 7:58 AM
Unknown Object (File)
Feb 25 2025, 3:39 AM
Unknown Object (File)
Feb 22 2025, 12:10 AM
Unknown Object (File)
Feb 11 2025, 10:30 AM
Unknown Object (File)
Feb 11 2025, 9:26 AM
Subscribers
None

Details

Summary

Fixes T12069. We implement "arc diff --reviewers" (and "--cc") by parsing a faux message with "Reviewers: ...".

After D17122, the first line of the message is always interpreted as a title, so the text ends up in the message body.

Instead, use a placeholder title so these fields are never initial fields.

Test Plan

Ran arc diff --reviewers dog, got only one "Reviewers" field.

Diff Detail

Repository
rARC Arcanist
Branch
placeholder
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15120
Build 19853: Run Core Tests
Build 19852: arc lint + arc unit