Page MenuHomePhabricator

Fix a bad interaction between "arc diff --reviewers" and "the first line of a message is always a title"
ClosedPublic

Authored by epriestley on Jan 5 2017, 10:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 5, 11:03 AM
Unknown Object (File)
Sat, Aug 10, 4:11 AM
Unknown Object (File)
Jul 27 2024, 8:16 PM
Unknown Object (File)
Jul 14 2024, 9:43 AM
Unknown Object (File)
Jul 13 2024, 1:00 PM
Unknown Object (File)
Jul 11 2024, 9:49 PM
Unknown Object (File)
Jul 9 2024, 11:44 AM
Unknown Object (File)
Jul 6 2024, 10:56 AM
Subscribers
None

Details

Summary

Fixes T12069. We implement "arc diff --reviewers" (and "--cc") by parsing a faux message with "Reviewers: ...".

After D17122, the first line of the message is always interpreted as a title, so the text ends up in the message body.

Instead, use a placeholder title so these fields are never initial fields.

Test Plan

Ran arc diff --reviewers dog, got only one "Reviewers" field.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable