Page MenuHomePhabricator

Fix a bad interaction between "arc diff --reviewers" and "the first line of a message is always a title"
ClosedPublic

Authored by epriestley on Jan 5 2017, 10:00 PM.
Tags
None
Referenced Files
F13060557: D17147.diff
Fri, Apr 19, 6:01 PM
F13053990: D17147.id41238.diff
Fri, Apr 19, 11:45 AM
Unknown Object (File)
Mon, Apr 15, 6:28 PM
Unknown Object (File)
Sat, Apr 13, 5:01 AM
Unknown Object (File)
Wed, Apr 3, 12:41 AM
Unknown Object (File)
Thu, Mar 28, 1:02 PM
Unknown Object (File)
Feb 3 2024, 1:46 PM
Unknown Object (File)
Jan 24 2024, 11:38 PM
Subscribers
None

Details

Summary

Fixes T12069. We implement "arc diff --reviewers" (and "--cc") by parsing a faux message with "Reviewers: ...".

After D17122, the first line of the message is always interpreted as a title, so the text ends up in the message body.

Instead, use a placeholder title so these fields are never initial fields.

Test Plan

Ran arc diff --reviewers dog, got only one "Reviewers" field.

Diff Detail

Repository
rARC Arcanist
Branch
placeholder
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15120
Build 19853: Run Core Tests
Build 19852: arc lint + arc unit