Page MenuHomePhabricator

Move Differential to EditEngine comments
ClosedPublic

Authored by epriestley on Dec 28 2016, 6:44 PM.
Tags
None
Referenced Files
F19684209: D17106.id41165.diff
Mon, Feb 9, 3:20 AM
F19668379: D17106.id.diff
Feb 7 2026, 6:54 PM
F18961328: D17106.diff
Nov 13 2025, 2:02 PM
F18877977: D17106.id.diff
Nov 6 2025, 1:28 PM
F18873859: D17106.diff
Nov 5 2025, 11:48 AM
F18761260: D17106.id.diff
Oct 6 2025, 1:18 PM
F18756608: D17106.diff
Oct 5 2025, 12:20 PM
F18669143: D17106.id.diff
Sep 24 2025, 6:54 PM
Subscribers
None

Details

Summary

Ref T11114. This is a transitional change that breaks a bunch of stuff. I'll hold it until I've restored features.

This stuff works:

  • Commenting.
  • Subscribers/tags/reviewers.
  • Pinning.
  • Drafts.

This stuff does not work yet:

  • Preview of inline comments.
  • Probably submitting inlines, whatsoever.
  • Comment-area warnings like "There are failing tests."
  • All meaningful actions (accept, reject, etc).
Test Plan

Commented on a revision. Essentially nothing else works yet.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable