Page MenuHomePhabricator

Move Differential to EditEngine comments
ClosedPublic

Authored by epriestley on Dec 28 2016, 6:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 9 2026, 5:38 AM
Unknown Object (File)
Apr 7 2026, 3:38 PM
Unknown Object (File)
Apr 7 2026, 9:36 AM
Unknown Object (File)
Feb 9 2026, 3:20 AM
Unknown Object (File)
Feb 7 2026, 6:54 PM
Unknown Object (File)
Nov 13 2025, 2:02 PM
Unknown Object (File)
Nov 6 2025, 1:28 PM
Unknown Object (File)
Nov 5 2025, 11:48 AM
Subscribers
None

Details

Summary

Ref T11114. This is a transitional change that breaks a bunch of stuff. I'll hold it until I've restored features.

This stuff works:

  • Commenting.
  • Subscribers/tags/reviewers.
  • Pinning.
  • Drafts.

This stuff does not work yet:

  • Preview of inline comments.
  • Probably submitting inlines, whatsoever.
  • Comment-area warnings like "There are failing tests."
  • All meaningful actions (accept, reject, etc).
Test Plan

Commented on a revision. Essentially nothing else works yet.

Diff Detail

Repository
rP Phabricator
Branch
haunt2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15031
Build 19719: Run Core Tests
Build 19718: arc lint + arc unit