Page MenuHomePhabricator

Move Differential to EditEngine comments
ClosedPublic

Authored by epriestley on Dec 28 2016, 6:44 PM.
Tags
None
Referenced Files
F14380155: D17106.id41144.diff
Sat, Dec 21, 3:38 AM
F14369707: D17106.id41144.diff
Fri, Dec 20, 5:07 PM
Unknown Object (File)
Thu, Dec 19, 4:02 PM
Unknown Object (File)
Thu, Dec 19, 4:19 AM
Unknown Object (File)
Sun, Dec 15, 10:46 AM
Unknown Object (File)
Sun, Dec 15, 1:58 AM
Unknown Object (File)
Tue, Dec 10, 5:10 PM
Unknown Object (File)
Sun, Dec 8, 8:27 PM
Subscribers
None

Details

Summary

Ref T11114. This is a transitional change that breaks a bunch of stuff. I'll hold it until I've restored features.

This stuff works:

  • Commenting.
  • Subscribers/tags/reviewers.
  • Pinning.
  • Drafts.

This stuff does not work yet:

  • Preview of inline comments.
  • Probably submitting inlines, whatsoever.
  • Comment-area warnings like "There are failing tests."
  • All meaningful actions (accept, reject, etc).
Test Plan

Commented on a revision. Essentially nothing else works yet.

Diff Detail

Repository
rP Phabricator
Branch
haunt2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15031
Build 19719: Run Core Tests
Build 19718: arc lint + arc unit