Page MenuHomePhabricator

Don't let users write summaries or test plans which will become ambiguous in commit messages
ClosedPublic

Authored by epriestley on Nov 12 2016, 3:14 PM.
Tags
None
Referenced Files
F14061233: D16846.diff
Mon, Nov 18, 5:41 AM
F14046340: D16846.diff
Wed, Nov 13, 8:23 PM
F14034253: D16846.diff
Sat, Nov 9, 11:12 PM
F14033821: D16846.diff
Sat, Nov 9, 8:17 PM
F14033635: D16846.diff
Sat, Nov 9, 6:48 PM
F14032009: D16846.id40568.diff
Sat, Nov 9, 12:34 PM
F14032008: D16846.id40565.diff
Sat, Nov 9, 12:34 PM
F14032007: D16846.id.diff
Sat, Nov 9, 12:34 PM
Subscribers
None

Details

Summary

Ref T11085. To recreate the issue:

  • From the web UI, click "Edit Revision".
  • Write something like this as your "Summary" (i.e., put another field marker, like "Test Plan:", into the summary):

This is a test of the
Test Plan: field to see
if it works.

  • Save changes.

Later, when the summary is amended into a commit message, the parser will see two "Test Plan:" fields and fail to parse the message.

Instead, prevent users from making this edit.

Test Plan

Screen Shot 2016-11-12 at 7.10.43 AM.png (846×2 px, 112 KB)

Diff Detail

Repository
rP Phabricator
Branch
ambig1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14457
Build 18844: Run Core Tests
Build 18843: arc lint + arc unit