Fix some slop with Differential field lists
ClosedPublic
Actions

Authored by epriestley on Nov 13 2016, 12:25 AM.

Tags

None

Referenced Files

	F14312733: D16849.id40572.diff
	Wed, Dec 18, 3:38 AM

	Unknown Object (File)
	Fri, Dec 13, 9:02 PM

	Unknown Object (File)
	Sat, Dec 7, 12:42 PM

	Unknown Object (File)
	Thu, Dec 5, 3:42 AM

	Unknown Object (File)
	Thu, Nov 28, 1:34 AM

	Unknown Object (File)
	Sun, Nov 24, 2:50 PM

	Unknown Object (File)
	Wed, Nov 20, 9:28 PM

	Unknown Object (File)
	Wed, Nov 20, 6:40 PM

View All Files

Subscribers

None

Details

Reviewers

chad
jacksongabbard

Commits

rP745429aac1ea: Fix some slop with Differential field lists

Summary

I moved and then un-moved this incorrectly in D16846.

Test Plan

Looked at the old code, which worked better.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40572.Nov 13 2016, 12:25 AM

epriestley retitled this revision from to Fix some slop with Differential field lists.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: jacksongabbard, chad.

chad accepted this revision.Nov 13 2016, 12:26 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 13 2016, 12:26 AM

Closed by commit rP745429aac1ea: Fix some slop with Differential field lists (authored by epriestley, committed by epriestley). · Explain WhyNov 13 2016, 12:27 AM

This revision was automatically updated to reflect the committed changes.

Macro happycat:

Don't get too excited, I'm going to break everything in a second.

pull now PULL NOW

too late

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

DifferentialParseCommitMessageConduitAPIMethod.php

2 lines

Diff 40573

View Options

src/applications/differential/conduit/DifferentialParseCommitMessageConduitAPIMethod.php

Fix some slop with Differential field listsClosedPublicActions