Page MenuHomePhabricator
Differential D16833

Remove plain-text file view of Diffusion files.
ClosedPublic
Actions

Authored by avivey on Nov 10 2016, 12:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 3:58 AM
Unknown Object (File)
Mon, Apr 22, 9:06 PM
Unknown Object (File)
Mon, Apr 22, 8:36 PM
Unknown Object (File)
Thu, Apr 18, 3:52 PM
Unknown Object (File)
Mon, Apr 8, 3:38 PM
Unknown Object (File)
Mon, Apr 8, 2:28 PM
Unknown Object (File)
Mon, Apr 8, 11:35 AM
Unknown Object (File)
Mon, Apr 8, 11:35 AM
View All Files
Subscribers
Korvin
Tokens
"Party Time" token, awarded by epriestley.

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T11792: Remove "No Highlighting" mode from Diffusion
Commits
rPe634812a6d36: Remove plain-text file view of Diffusion files.
Summary

fixes T11792.
There's no good reason any more to have this option, so just drop it.

Test Plan

Load a file, toggle remaining "blame" button. Load search results page and an image too, which are serviced by the same controller.

Diff Detail

Repository
rP Phabricator
Branch
no-plaintext-diffusion
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14428
Build 18802: Run Core Tests
Build 18801: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 40537.Nov 10 2016, 12:33 AM
avivey retitled this revision from to Remove plain-text file view of Diffusion files..
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added reviewers: epriestley, chad.
avivey added a task: T11792: Remove "No Highlighting" mode from Diffusion.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 10 2016, 12:33 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 10 2016, 12:35 AM
epriestley edited edge metadata.

Also throw out PhabricatorDiffusionColorSetting::SETTINGKEY?

src/applications/diffusion/controller/DiffusionBrowseController.php
108–109

Nuke this too?

This revision is now accepted and ready to land.Nov 10 2016, 12:35 AM
epriestley added a comment.Nov 10 2016, 12:36 AM
In D16833#198960, @epriestley wrote:

Also throw out PhabricatorDiffusionColorSetting::SETTINGKEY?

Er, I mean the whole class (PhabricatorDiffusionColorSetting).

avivey updated this revision to Diff 40538.Nov 10 2016, 12:38 AM
avivey edited edge metadata.
  • delete the setting!
epriestley awarded a token.Nov 10 2016, 12:39 AM
Closed by commit rPe634812a6d36: Remove plain-text file view of Diffusion files. (authored by avivey, committed by avivey). · Explain WhyNov 10 2016, 12:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
diffusion/
controller/
260 lines
settings/
setting/

Diff 40538

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
View Options

src/applications/settings/setting/PhabricatorDiffusionColorSetting.php

Loading...
Phabricator · Built by Phacility