Page MenuHomePhabricator

Remove plain-text file view of Diffusion files.
ClosedPublic

Authored by avivey on Nov 10 2016, 12:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 5 2024, 7:18 PM
Unknown Object (File)
Jan 30 2024, 4:51 PM
Unknown Object (File)
Jan 26 2024, 4:52 PM
Unknown Object (File)
Jan 23 2024, 9:32 AM
Unknown Object (File)
Jan 22 2024, 4:45 PM
Unknown Object (File)
Jan 18 2024, 4:33 PM
Unknown Object (File)
Jan 16 2024, 2:52 PM
Unknown Object (File)
Jan 14 2024, 4:37 PM
Subscribers
Tokens
"Party Time" token, awarded by epriestley.

Details

Summary

fixes T11792.
There's no good reason any more to have this option, so just drop it.

Test Plan

Load a file, toggle remaining "blame" button. Load search results page and an image too, which are serviced by the same controller.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey retitled this revision from to Remove plain-text file view of Diffusion files..
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added reviewers: epriestley, chad.
epriestley edited edge metadata.

Also throw out PhabricatorDiffusionColorSetting::SETTINGKEY?

src/applications/diffusion/controller/DiffusionBrowseController.php
108–109

Nuke this too?

This revision is now accepted and ready to land.Nov 10 2016, 12:35 AM

Also throw out PhabricatorDiffusionColorSetting::SETTINGKEY?

Er, I mean the whole class (PhabricatorDiffusionColorSetting).

avivey edited edge metadata.
  • delete the setting!
This revision was automatically updated to reflect the committed changes.