Page MenuHomePhabricator
Differential D16572

Removed willProcessRequest from DifferentialRevisionLandController
ClosedPublic
Actions

Authored by jcox on Sep 19 2016, 1:19 PM.
Tags
None
Referenced Files
F14832775: D16572.id39884.diff
Thu, Jan 30, 6:47 AM
F14832312: D16572.id39890.diff
Thu, Jan 30, 4:42 AM
Unknown Object (File)
Wed, Jan 29, 1:05 AM
Unknown Object (File)
Fri, Jan 24, 1:39 AM
Unknown Object (File)
Tue, Jan 21, 3:11 PM
Unknown Object (File)
Tue, Jan 21, 11:53 AM
Unknown Object (File)
Sat, Jan 18, 2:14 AM
Unknown Object (File)
Fri, Jan 17, 10:24 PM
View All Files
Subscribers
epriestley
Korvin
yelirekim

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8628: Modernize AphrontControllers to implement handleRequest
Commits
rPadf9d5ffdd61: Removed willProcessRequest from DifferentialRevisionLandController
Summary

Ref T8628.

Test Plan

Landed a revision through the web UI

Diff Detail

Repository
rP Phabricator
Branch
RevLandAphrontUpdate (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13764
Build 17778: Run Core Tests
Build 17777: arc lint + arc unit

Event Timeline

jcox updated this revision to Diff 39884.Sep 19 2016, 1:19 PM
jcox retitled this revision from to Removed willProcessRequest from DifferentialRevisionLandController.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
jcox added a task: T8628: Modernize AphrontControllers to implement handleRequest.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 19 2016, 1:19 PM
Herald added subscribers: yelirekim, epriestley. · View Herald Transcript
jcox edited the test plan for this revision. (Show Details)Sep 19 2016, 1:50 PM
jcox edited edge metadata.
epriestley accepted this revision.Sep 19 2016, 5:08 PM
epriestley added a reviewer: epriestley.

This code isn't actually reachable ("Land Revision" in the web UI uses DifferentialRevisionOperationController, not this one) but it's being retained purely for backward compatibility until "Land Revision" has a better story on auth-to-GitHub stuff which this older thing technically sort-of supports.

This revision is now accepted and ready to land.Sep 19 2016, 5:08 PM
jcox added a comment.Sep 19 2016, 5:23 PM

ah gotcha. Should I land this anyway or just leave it be?

epriestley added a comment.Sep 19 2016, 5:45 PM

Just land it, if this somehow breaks things (unlikely) this code was slated for removal anyway.

jcox updated this revision to Diff 39889.Sep 19 2016, 5:47 PM
jcox edited edge metadata.

Rebase

Herald added a subscriber: Korvin. · View Herald TranscriptSep 19 2016, 5:47 PM
Closed by commit rPadf9d5ffdd61: Removed willProcessRequest from DifferentialRevisionLandController (authored by jcox, committed by jcox). · Explain WhySep 19 2016, 5:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
17 lines

Diff 39884

View Options

src/applications/differential/controller/DifferentialRevisionLandController.php

Loading...
Phabricator · Built by Phacility