Page MenuHomePhabricator

Removed willProcessRequest from DifferentialRevisionLandController
ClosedPublic

Authored by jcox on Sep 19 2016, 1:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 28 2024, 6:16 PM
Unknown Object (File)
Dec 27 2023, 9:04 AM
Unknown Object (File)
Dec 27 2023, 9:04 AM
Unknown Object (File)
Dec 27 2023, 9:04 AM
Unknown Object (File)
Dec 27 2023, 9:04 AM
Unknown Object (File)
Dec 25 2023, 8:48 PM
Unknown Object (File)
Dec 22 2023, 4:04 PM
Unknown Object (File)
Dec 21 2023, 4:24 PM

Details

Diff Detail

Repository
rP Phabricator
Branch
RevLandAphrontUpdate (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13764
Build 17778: Run Core Tests
Build 17777: arc lint + arc unit

Event Timeline

jcox retitled this revision from to Removed willProcessRequest from DifferentialRevisionLandController.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
jcox edited edge metadata.
epriestley added a reviewer: epriestley.

This code isn't actually reachable ("Land Revision" in the web UI uses DifferentialRevisionOperationController, not this one) but it's being retained purely for backward compatibility until "Land Revision" has a better story on auth-to-GitHub stuff which this older thing technically sort-of supports.

This revision is now accepted and ready to land.Sep 19 2016, 5:08 PM

ah gotcha. Should I land this anyway or just leave it be?

Just land it, if this somehow breaks things (unlikely) this code was slated for removal anyway.

jcox edited edge metadata.

Rebase

This revision was automatically updated to reflect the committed changes.