Page MenuHomePhabricator

Fix Herald test adapter for commits
ClosedPublic

Authored by epriestley on Aug 17 2016, 3:37 PM.
Tags
None
Referenced Files
F15405294: D16413.id.diff
Tue, Mar 18, 11:00 AM
F15383709: D16413.diff
Fri, Mar 14, 5:39 PM
F15337760: D16413.id39464.diff
Sun, Mar 9, 7:37 AM
F15307253: D16413.id39465.diff
Thu, Mar 6, 4:55 AM
Unknown Object (File)
Sat, Mar 1, 11:04 AM
Unknown Object (File)
Sat, Feb 22, 5:02 AM
Unknown Object (File)
Tue, Feb 18, 11:36 AM
Unknown Object (File)
Tue, Feb 18, 10:01 AM
Subscribers
None

Details

Summary

Fixes T11488. I broke this in D16360, I think by doing a little extra refactoring after testing it.

This code is very old, before commits always needed to have repositories attached in order to do policy checks.

Modernize it by mostly just using the repository which is present on the Commit object, and using the existing edge cache.

Test Plan

Ran a commit through the Herald test adapter.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable