HomePhabricator

Fix Herald test adapter for commits

Description

Fix Herald test adapter for commits

Summary:
Fixes T11488. I broke this in D16360, I think by doing a little extra refactoring after testing it.

This code is very old, before commits always needed to have repositories attached in order to do policy checks.

Modernize it by mostly just using the repository which is present on the Commit object, and using the existing edge cache.

Test Plan: Ran a commit through the Herald test adapter.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11488

Differential Revision: https://secure.phabricator.com/D16413

Details

Provenance
epriestleyAuthored on Aug 17 2016, 3:34 PM
epriestleyPushed on Aug 17 2016, 4:02 PM
Reviewer
chad
Differential Revision
D16413: Fix Herald test adapter for commits
Parents
rPf46cf99274d1: Fix a typo in "Internationalization" documentation
Branches
Unknown
Tags
Unknown
Tasks
T11488: Herald Test thinks commits are not objects
Build Status
Buildable 13345
Build 17121: Run Core Tests