Page MenuHomePhabricator

Fix Herald test adapter for commits
ClosedPublic

Authored by epriestley on Aug 17 2016, 3:37 PM.
Tags
None
Referenced Files
F13239873: D16413.id.diff
Wed, May 22, 7:28 AM
F13220550: D16413.diff
Sun, May 19, 1:40 AM
F13202884: D16413.diff
Tue, May 14, 11:14 PM
F13199380: D16413.id39464.diff
Mon, May 13, 2:08 PM
F13185207: D16413.diff
Sat, May 11, 2:40 AM
F13182980: D16413.id39465.diff
Fri, May 10, 5:44 AM
Unknown Object (File)
Tue, May 7, 5:04 AM
Unknown Object (File)
Fri, May 3, 2:31 AM
Subscribers
None

Details

Summary

Fixes T11488. I broke this in D16360, I think by doing a little extra refactoring after testing it.

This code is very old, before commits always needed to have repositories attached in order to do policy checks.

Modernize it by mostly just using the repository which is present on the Commit object, and using the existing edge cache.

Test Plan

Ran a commit through the Herald test adapter.

Diff Detail

Repository
rP Phabricator
Branch
hcommit
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13344
Build 17120: Run Core Tests
Build 17119: arc lint + arc unit