Page MenuHomePhabricator

Give prose diffs some basic test coverage
ClosedPublic

Authored by epriestley on Jun 7 2016, 3:06 PM.
Tags
None
Referenced Files
F15408017: D16067.id38659.diff
Tue, Mar 18, 8:53 PM
F15378640: D16067.id38663.diff
Thu, Mar 13, 3:51 PM
F15284265: D16067.diff
Tue, Mar 4, 9:29 AM
F15282507: D16067.id38659.diff
Tue, Mar 4, 12:17 AM
Unknown Object (File)
Mon, Mar 3, 1:30 AM
Unknown Object (File)
Mon, Feb 24, 7:05 AM
Unknown Object (File)
Feb 16 2025, 6:56 AM
Unknown Object (File)
Feb 9 2025, 1:45 AM
Subscribers
None

Details

Summary

Ref T7643. This strategy looks like it's a reasonable way to get these diffs to "pretty good, most of the time" levels. Since I'm not plannign to throw it away, start adding some test coverage.

Test Plan

Ran unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
prose6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12531
Build 15893: Run Core Tests
Build 15892: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Give prose diffs some basic test coverage.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2016, 3:11 PM
This revision was automatically updated to reflect the committed changes.