Page MenuHomePhabricator

Give prose diffs some basic test coverage
ClosedPublic

Authored by epriestley on Jun 7 2016, 3:06 PM.
Tags
None
Referenced Files
F18848990: D16067.id.diff
Thu, Oct 30, 7:12 AM
F18834233: D16067.diff
Sun, Oct 26, 7:25 AM
F18831136: D16067.id38663.diff
Sat, Oct 25, 11:12 AM
F18811078: D16067.id38659.diff
Oct 20 2025, 12:53 AM
F18757297: D16067.diff
Oct 5 2025, 4:43 PM
F18736759: D16067.id38663.diff
Oct 1 2025, 7:44 AM
F18631681: D16067.id.diff
Sep 16 2025, 4:16 PM
F18621412: D16067.diff
Sep 15 2025, 8:12 AM
Subscribers
None

Details

Summary

Ref T7643. This strategy looks like it's a reasonable way to get these diffs to "pretty good, most of the time" levels. Since I'm not plannign to throw it away, start adding some test coverage.

Test Plan

Ran unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give prose diffs some basic test coverage.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2016, 3:11 PM
This revision was automatically updated to reflect the committed changes.