Page MenuHomePhabricator

Give prose diffs some basic test coverage
ClosedPublic

Authored by epriestley on Jun 7 2016, 3:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 4:51 PM
Unknown Object (File)
Fri, Apr 19, 4:34 AM
Unknown Object (File)
Tue, Apr 16, 2:38 PM
Unknown Object (File)
Fri, Apr 12, 2:38 AM
Unknown Object (File)
Tue, Apr 2, 4:38 PM
Unknown Object (File)
Sun, Mar 31, 2:31 PM
Unknown Object (File)
Fri, Mar 29, 7:41 AM
Unknown Object (File)
Mar 21 2024, 10:26 PM
Subscribers
None

Details

Summary

Ref T7643. This strategy looks like it's a reasonable way to get these diffs to "pretty good, most of the time" levels. Since I'm not plannign to throw it away, start adding some test coverage.

Test Plan

Ran unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
prose6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12531
Build 15893: Run Core Tests
Build 15892: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Give prose diffs some basic test coverage.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2016, 3:11 PM
This revision was automatically updated to reflect the committed changes.