HomePhabricator

Slightly improve prose diffs for text ending in newlines or punctuation

Description

Slightly improve prose diffs for text ending in newlines or punctuation

Summary:
Ref T3353. Currently, if text ends in newlines (or some other types of punctuation) we generate an extra piece at the end which can muck up the algorithm.

Do a slightly better job with this.

Test Plan: Viewed a diff between "a\nb\nc\n" and "a\nb\nc\nd\n", got a cleaner diff out of it.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T3353

Differential Revision: https://secure.phabricator.com/D16061

Details

Provenance
epriestleyAuthored on Jun 6 2016, 8:48 PM
epriestleyPushed on Jun 6 2016, 9:01 PM
Reviewer
chad
Differential Revision
D16061: Slightly improve prose diffs for text ending in newlines or punctuation
Parents
rPHUb3aa54fb9460: Very rough cut of prose diffs
Branches
Unknown
Tags
Unknown
Tasks
T3353: Make Phriction Document changes reviewable
Build Status
Buildable 12518
Build 15874: Run Core Tests