Differential D16041

Cache user notification and message counts
ClosedPublic
Actions

Authored by epriestley on Jun 5 2016, 1:54 AM.

Tags

None

Referenced Files

	F14347851: D16041.diff
	Thu, Dec 19, 3:42 AM

	Unknown Object (File)
	Mon, Dec 16, 10:39 AM

	Unknown Object (File)
	Sat, Dec 14, 9:47 AM

	Unknown Object (File)
	Thu, Dec 12, 10:54 PM

	Unknown Object (File)
	Wed, Dec 11, 6:47 AM

	Unknown Object (File)
	Thu, Dec 5, 11:24 AM

	Unknown Object (File)
	Wed, Dec 4, 12:15 PM

	Unknown Object (File)
	Wed, Nov 27, 11:11 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T4103: Implement "Role Profiles" to provide search, homepage and application defaults
T10078: Implement global readthrough cache pools

Commits

rPc1331bcb7ba6: Cache user notification and message counts

Summary

Ref T4103. Ref T10078. This puts a user cache in front of notification and message counts.

This reduces the number of queries issued on every page by 4 (2x building the menu, 2x building Quicksand data).

Also fixes some minor issues:

Daemons could choke on sending mail in the user's translation.
No-op object updates could fail in the daemons.
Questionable data access pattern in the file query coming out of the profile file cache.

Test Plan

Sent myself notifications. Saw count go up.
Cleared them by visiting objects and clearing all notifications. Saw count go down.
Sent myself messages. Saw count go up.
Cleared them by visiting threads. Saw count go down.

Diff Detail

Repository

Branch

setting30

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12463
Build 15792: Run Core Tests
Build 15791: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	50 ms	PhabricatorAccessControlTestCase::Unknown Unit Message ("") Assertion failed, expected 'true' (at PhabricatorAccessControlTestCase.php:261): Expect user 'normal' to be allowed access to 'Default'. ACTUAL VALUE
	0 ms	PhabricatorLocalTimeTestCase::Unknown Unit Message ("") EXCEPTION (PhabricatorDataNotAttachedException): Attempting to access attached data on PhabricatorUser (via getUserSetting()), but the data is not actually attached. Before accessing attachable data on an object, you must load and attach it. Data is normally attached by calling the corresponding needX() method on the Query class when the object is loaded. You can also call the corresponding attachX() method explicitly.
	0 ms	AlmanacNamesTestCase::Unknown Unit Message ("") 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("") 1 assertion passed.
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 6 assertions passed.
		View Full Test Results (2 Failed · 327 Passed)

Event Timeline

epriestley updated this revision to Diff 38592.Jun 5 2016, 1:54 AM

epriestley retitled this revision from to Cache user notification and message counts.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10078: Implement global readthrough cache pools, T4103: Implement "Role Profiles" to provide search, homepage and application defaults.

epriestley mentioned this in D16040: Convert user profile images into a standard cache.Jun 5 2016, 3:58 AM

Rebase on D16042 to fix tests.

chad accepted this revision.Jun 5 2016, 2:54 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 5 2016, 2:54 PM

Closed by commit rPc1331bcb7ba6: Cache user notification and message counts (authored by epriestley, committed by epriestley). · Explain WhyJun 5 2016, 3:52 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T11097: Pop-up notifications picked up a timestamp as a side effect.Jun 5 2016, 5:29 PM

epriestley mentioned this in D16258: Strip timestamps from popup notification bubbles.Jul 8 2016, 2:41 PM

epriestley mentioned this in rPbd6d300282ec: Strip timestamps from popup notification bubbles.Jul 8 2016, 2:46 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

applications/

aphlict/

query/

AphlictDropdownDataQuery.php

24 lines

conpherence/

controller/

ConpherenceViewController.php

9 lines

editor/

ConpherenceEditor.php

4 lines

storage/

ConpherenceParticipant.php

7 lines

feed/

PhabricatorFeedStoryPublisher.php

7 lines

files/

query/

PhabricatorFileQuery.php

10 lines

metamta/

replyhandler/

PhabricatorMailReplyHandler.php

3 lines

notification/

controller/

PhabricatorNotificationClearController.php

4 lines

PhabricatorNotificationPanelController.php

3 lines

storage/

PhabricatorFeedStoryNotification.php

16 lines

people/

cache/

PhabricatorUserMessageCountCacheType.php

45 lines

PhabricatorUserNotificationCountCacheType.php

50 lines

storage/

PhabricatorUser.php

10 lines

PhabricatorUserCache.php

13 lines

settings/

editor/

PhabricatorUserPreferencesEditor.php

1 line

transactions/

worker/

PhabricatorApplicationTransactionPublishWorker.php

6 lines

Diff 38592

src/__phutil_library_map__.php

Loading...

src/applications/aphlict/query/AphlictDropdownDataQuery.php

Loading...

src/applications/conpherence/controller/ConpherenceViewController.php

Loading...

src/applications/conpherence/editor/ConpherenceEditor.php

Loading...

src/applications/conpherence/storage/ConpherenceParticipant.php

Loading...

src/applications/feed/PhabricatorFeedStoryPublisher.php

Loading...

src/applications/files/query/PhabricatorFileQuery.php

Loading...

src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php

Loading...

src/applications/notification/controller/PhabricatorNotificationClearController.php

Loading...

src/applications/notification/controller/PhabricatorNotificationPanelController.php

Loading...

src/applications/notification/storage/PhabricatorFeedStoryNotification.php

Loading...

src/applications/people/cache/PhabricatorUserMessageCountCacheType.php

Loading...

src/applications/people/cache/PhabricatorUserNotificationCountCacheType.php

Loading...

src/applications/people/storage/PhabricatorUser.php

Loading...

src/applications/people/storage/PhabricatorUserCache.php

Loading...

src/applications/settings/editor/PhabricatorUserPreferencesEditor.php

Loading...

src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php

Loading...