Page MenuHomePhabricator
Differential D16258

Strip timestamps from popup notification bubbles
ClosedPublic
Actions

Authored by epriestley on Jul 8 2016, 2:41 PM.
Tags
None
Referenced Files
F18779565: D16258.id39108.diff
Sat, Oct 11, 2:30 PM
F18753631: D16258.id39105.diff
Sat, Oct 4, 7:41 PM
F18749999: D16258.id39105.diff
Sat, Oct 4, 6:04 AM
F18749997: D16258.id39108.diff
Sat, Oct 4, 6:04 AM
F18749996: D16258.id.diff
Sat, Oct 4, 6:04 AM
F18702914: D16258.diff
Sun, Sep 28, 2:07 AM
F18628079: D16258.diff
Tue, Sep 16, 5:32 AM
F18567474: D16258.id.diff
Sep 9 2025, 3:49 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11097: Pop-up notifications picked up a timestamp as a side effect
Commits
rPbd6d300282ec: Strip timestamps from popup notification bubbles
Summary

Fixes T11097. Currently, popup notifications show a useless timestamp with the current time, after D16041 made some things more consistent.

Strip these from the popup bubbles.

Test Plan
  • Saw a popup bubble, no timestamp.
  • Viewed main notification list, saw timestamps.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39105.Jul 8 2016, 2:41 PM
epriestley retitled this revision from to Strip timestamps from popup notification bubbles.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11097: Pop-up notifications picked up a timestamp as a side effect.
chad accepted this revision.Jul 8 2016, 2:45 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 8 2016, 2:45 PM
Closed by commit rPbd6d300282ec: Strip timestamps from popup notification bubbles (authored by epriestley, committed by epriestley). · Explain WhyJul 8 2016, 2:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
notification/
builder/
13 lines
controller/
3 lines
view/
phui/
37 lines

Diff 39108

View Options

src/applications/notification/builder/PhabricatorNotificationBuilder.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationIndividualController.php

Loading...
View Options

src/view/phui/PHUIFeedStoryView.php

Loading...
Phabricator · Built by Phacility