Page MenuHomePhabricator

Make caches misses throw by default intead of inline-generating
ClosedPublic

Authored by epriestley on Jun 5 2016, 1:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:52 AM
Unknown Object (File)
Fri, Apr 19, 4:49 PM
Unknown Object (File)
Fri, Apr 12, 8:20 AM
Unknown Object (File)
Thu, Apr 11, 10:18 AM
Unknown Object (File)
Sun, Mar 31, 2:30 PM
Unknown Object (File)
Sun, Mar 31, 1:40 AM
Unknown Object (File)
Sun, Mar 31, 1:40 AM
Unknown Object (File)
Sun, Mar 31, 1:40 AM
Subscribers
None

Details

Summary

Ref T4103. Ref T10078. Currently, when a user misses a cache we just build it for them.

This is the behavior we want for the the viewer (so we don't have to build every cache up front if we don't actually need them), but not the right behavior for other users (since it allows performance problems to go undetected).

Make inline cache generation strict by default, then make sure all the things that rely on cache data request the correct data (well, all of the things identified by unit tests, at least: there might be some more stuff I haven't hit yet).

This fixes test failures in D16040, and backports a piece of that change.

Test Plan

Identified and then fixed failures with arc unit --everything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make caches misses throw by default intead of inline-generating.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Fix a property name typo.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 5 2016, 2:59 PM
This revision was automatically updated to reflect the committed changes.