Paths

Table of Contentst

Differential D15350

When the push phase of "Land Revision" fails, show the error in the UI
ClosedPublic
Actions

Authored by nickz on Feb 26 2016, 5:36 AM.

Tags

None

Referenced Files

	F13146367: D15350.diff
	Fri, May 3, 10:01 AM

	Unknown Object (File)
	Mon, Apr 29, 4:54 PM

	Unknown Object (File)
	Mon, Apr 29, 4:54 PM

	Unknown Object (File)
	Mon, Apr 29, 4:54 PM

	Unknown Object (File)
	Mon, Apr 29, 4:54 PM

	Unknown Object (File)
	Thu, Apr 25, 5:41 PM

	Unknown Object (File)
	Thu, Apr 25, 3:25 AM

	Unknown Object (File)
	Fri, Apr 19, 4:15 PM

Subscribers

Tokens

"Like" token, awarded by epriestley.

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP6861af0cbb0b: When the push phase of "Land Revision" fails, show the error in the UI

Summary

Test Plan

tested on my dev instance

Diff Detail

Repository

Branch

Show_Push_in_UI

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 10851
Build 13377: arc lint + arc unit

Event Timeline

nickz updated this revision to Diff 37011.Feb 26 2016, 5:36 AM

nickz retitled this revision from to When the push phase of "Land Revision" fails, show the error in the UI.

nickz updated this object.

nickz edited the test plan for this revision. (Show Details)

nickz added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 26 2016, 5:36 AM

Herald added subscribers: yelirekim, Korvin. · View Herald Transcript

remove the change made by accident

This looks great, thanks! One minor typo inline.

src/applications/drydock/view/DrydockRepositoryOperationStatusView.php
89	Small typo: "custome" -> "custom" Maybe don't say "git" because we'll probably use the same message for Mercurial in the future. This probably reads a little more naturally as "...commit hook has failed" than "...commit hooks fail". So maybe something like this, overall: The push failed. This usually indicates that the change is breaking some rules or some custom commit hook has failed.

This revision is now accepted and ready to land.Feb 26 2016, 2:20 PM

epriestley awarded a token.Feb 26 2016, 2:20 PM

Closed by commit rP6861af0cbb0b: When the push phase of "Land Revision" fails, show the error in the UI (authored by nickz, committed by nickz). · Explain WhyFeb 26 2016, 5:38 PM

This revision was automatically updated to reflect the committed changes.

nickz marked an inline comment as done.

epriestley mentioned this in T10447: When the push phase of "Land Revision" fails, show the error in the UI.Feb 26 2016, 6:30 PM

joshuaspence added a subscriber: joshuaspence.Feb 27 2016, 2:03 AM

joshuaspence added inline comments.

src/applications/drydock/DrydockCommandError/DrydockCommandError.php
4	Hm, I'm surprised that the linter did not complain about this... This class should be marked ad `final` and should extend from `Phobject`.
src/applications/drydock/operation/DrydockLandRepositoryOperation.php
132	It would be better to move this to a variable to avoid code duplication.
133	Wrong indentation.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

12 lines

applications/

drydock/

DrydockCommandError/

DrydockCommandError.php

18 lines

blueprint/

DrydockWorkingCopyBlueprintImplementation.php

24 lines

operation/

DrydockLandRepositoryOperation.php

16 lines

storage/

DrydockRepositoryOperation.php

4 lines

view/

DrydockRepositoryOperationStatusView.php

8 lines

worker/

DrydockRepositoryOperationUpdateWorker.php

4 lines

Diff 37012

src/__phutil_library_map__.php

Loading...

src/applications/drydock/DrydockCommandError/DrydockCommandError.php

Loading...

src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php

Loading...

src/applications/drydock/operation/DrydockLandRepositoryOperation.php

Loading...

src/applications/drydock/storage/DrydockRepositoryOperation.php

Loading...

src/applications/drydock/view/DrydockRepositoryOperationStatusView.php

Loading...

src/applications/drydock/worker/DrydockRepositoryOperationUpdateWorker.php

Loading...