Page MenuHomePhabricator
Differential D14577

Improve error handling in `arc install-certificate`
ClosedPublic
Actions

Authored by epriestley on Nov 27 2015, 4:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 9:01 PM
Unknown Object (File)
Wed, Nov 27, 2:10 PM
Unknown Object (File)
Mon, Nov 25, 10:42 PM
Unknown Object (File)
Fri, Nov 15, 4:07 AM
Unknown Object (File)
Mon, Nov 11, 6:15 AM
Unknown Object (File)
Sat, Nov 9, 10:47 AM
Unknown Object (File)
Sat, Nov 9, 10:47 AM
Unknown Object (File)
Sat, Nov 9, 10:47 AM
View All Files
Subscribers
None

Details

Reviewers
joshuaspence
chad
Maniphest Tasks
T9858: Cryptic error message when running `arc install certificate`
Commits
rARC4f1141d0c59b: Improve error handling in `arc install-certificate`
Summary

Fixes T9858. Reasonable typos and misunderstandings currently produce very confusing error messages.

Test Plan
$ arc install certificate
Usage Exception: Server URI "certificate" must include a protocol and domain. It should be in the form "https://phabricator.example.com/".
  • Also used a good URI.
  • Also used no URI.

Diff Detail

Repository
rARC Arcanist
Branch
icert
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9078
Build 10689: Run Core Tests
Build 10688: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35269.Nov 27 2015, 4:37 PM
epriestley retitled this revision from to Improve error handling in `arc install-certificate`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, joshuaspence.
epriestley added a task: T9858: Cryptic error message when running `arc install certificate`.
chad accepted this revision.Nov 27 2015, 5:05 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 27 2015, 5:05 PM
Closed by commit rARC4f1141d0c59b: Improve error handling in `arc install-certificate` (authored by epriestley, committed by epriestley). · Explain WhyNov 27 2015, 5:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
workflow/
23 lines

Diff 35269

View Options

src/workflow/ArcanistInstallCertificateWorkflow.php

Loading...
Phabricator · Built by Phacility