Paths

Table of Contentst

Diffusion Arcanist eeaa176cfc5a

Add a linter rule to ensure that `namespace` is the first statement in a file
eeaa176cfc5a
Actions

Description

Add a linter rule to ensure that namespace is the first statement in a file

Summary: If a namespace is used within a PHP script, it must be the first statement.

Test Plan: Added unit tests.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14526

Details

Provenance

joshuaspence	Authored on
joshuaspence	Pushed on Nov 25 2015, 8:36 PM

Reviewer

Blessed Reviewers

Differential Revision

D14526: Add a linter rule to ensure that `namespace` is the first statement in a file

Parents

rARC600dcf83dd11: Fix linter rule ID

Branches

Unknown

Tags

Unknown

Build Status

Buildable 9072
Build 10679: Run Core Tests

Event Timeline

joshuaspence committed rARCeeaa176cfc5a: Add a linter rule to ensure that `namespace` is the first statement in a file (authored by joshuaspence).Nov 25 2015, 8:34 PM

Harbormaster completed building B9072: rARCeeaa176cfc5a: Add a linter rule to ensure that `namespace` is the first statement in a file.Nov 25 2015, 8:37 PM

Changes (8)

Path

Size

src/

__phutil_library_map__.php

lint/

linter/

xhpast/

rules/

ArcanistNamespaceFirstStatementXHPASTLinterRule.php

__tests__/

	ArcanistNamespaceFirstStatementXHPASTLinterRuleTestCase.php
	ArcanistBinaryExpressionSpacingXHPASTLinterRuleTestCase.php

namespace-first-statement

incorrect.lint-test

multiple-namespaces.lint-test

	xhpast/	rules/	__tests__/	namespace-first-statement/
			__tests__/	xhpast/

	class-before-namespace.lint-test
	syntax-error.lint-test

	no-namespace.lint-test
	no-segfault-on-exit.lint-test

rARCeeaa176cfc5a

View Options

src/__phutil_library_map__.php

View Options

src/lint/linter/xhpast/rules/ArcanistNamespaceFirstStatementXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/ArcanistNamespaceFirstStatementXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/tests/namespace-first-statement/class-before-namespace.lint-test

View Options

src/lint/linter/xhpast/rules/tests/namespace-first-statement/incorrect.lint-test

View Options

src/lint/linter/xhpast/rules/tests/namespace-first-statement/multiple-namespaces.lint-test

View Options

src/lint/linter/xhpast/rules/tests/namespace-first-statement/no-namespace.lint-test

Add a linter rule to ensure that `namespace` is the first statement in a fileeeaa176cfc5aActions

Description

Details

Event Timeline

Changes (8)

rARCeeaa176cfc5a

src/__phutil_library_map__.php

src/lint/linter/xhpast/rules/ArcanistNamespaceFirstStatementXHPASTLinterRule.php

src/lint/linter/xhpast/rules/__tests__/ArcanistNamespaceFirstStatementXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/namespace-first-statement/class-before-namespace.lint-test

src/lint/linter/xhpast/rules/__tests__/namespace-first-statement/incorrect.lint-test

src/lint/linter/xhpast/rules/__tests__/namespace-first-statement/multiple-namespaces.lint-test

src/lint/linter/xhpast/rules/__tests__/namespace-first-statement/no-namespace.lint-test

Add a linter rule to ensure that `namespace` is the first statement in a file
eeaa176cfc5a
Actions

src/lint/linter/xhpast/rules/tests/ArcanistNamespaceFirstStatementXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/namespace-first-statement/class-before-namespace.lint-test

src/lint/linter/xhpast/rules/tests/namespace-first-statement/incorrect.lint-test

src/lint/linter/xhpast/rules/tests/namespace-first-statement/multiple-namespaces.lint-test

src/lint/linter/xhpast/rules/tests/namespace-first-statement/no-namespace.lint-test