Page MenuHomePhabricator

Improve error handling in `arc install-certificate`
ClosedPublic

Authored by epriestley on Nov 27 2015, 4:37 PM.
Tags
None
Referenced Files
F15397808: D14577.id.diff
Sun, Mar 16, 10:23 PM
F15388864: D14577.id35269.diff
Sat, Mar 15, 4:33 AM
F15384627: D14577.id35270.diff
Fri, Mar 14, 8:26 PM
F15368918: D14577.diff
Wed, Mar 12, 4:32 AM
F15345432: D14577.diff
Mon, Mar 10, 10:20 AM
F15332055: D14577.id35270.diff
Fri, Mar 7, 4:26 PM
Unknown Object (File)
Thu, Feb 27, 11:13 AM
Unknown Object (File)
Feb 8 2025, 11:53 PM
Subscribers
None

Details

Summary

Fixes T9858. Reasonable typos and misunderstandings currently produce very confusing error messages.

Test Plan
$ arc install certificate
Usage Exception: Server URI "certificate" must include a protocol and domain. It should be in the form "https://phabricator.example.com/".
  • Also used a good URI.
  • Also used no URI.

Diff Detail

Repository
rARC Arcanist
Branch
icert
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9078
Build 10689: Run Core Tests
Build 10688: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Improve error handling in `arc install-certificate`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, joshuaspence.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 27 2015, 5:05 PM
This revision was automatically updated to reflect the committed changes.