(I vaguely wonder if we should have a PhabricatorWhateverApplication::APPCONST sort of constant, mostly to get better static analyzability, but that's easy to add later.)

This revision is now accepted and ready to land.Sep 6 2015, 2:58 PM

• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM

chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Rebase

Oh, I forgot about this -- this resolves T9625.

joshuaspence updated this object.Nov 2 2015, 7:46 PM

Closed by commit rP495cb7a2e037: Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 2 2015, 7:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

applications/

almanac/

phid/

AlmanacBindingPHIDType.php

4 lines

21%

AlmanacDevicePHIDType.php

4 lines

18%

AlmanacInterfacePHIDType.php

4 lines

12%

AlmanacNetworkPHIDType.php

4 lines

18%

AlmanacServicePHIDType.php

4 lines

18%

auth/

phid/

PhabricatorAuthAuthFactorPHIDType.php

4 lines

27%

PhabricatorAuthAuthProviderPHIDType.php

4 lines

25%

PhabricatorAuthInvitePHIDType.php

4 lines

30%

calendar/

phid/

PhabricatorCalendarEventPHIDType.php

8 lines

config/

phid/

PhabricatorConfigConfigPHIDType.php

4 lines

21%

countdown/

phid/

PhabricatorCountdownCountdownPHIDType.php

4 lines

dashboard/

phid/

PhabricatorDashboardDashboardPHIDType.php

4 lines

21%

PhabricatorDashboardPanelPHIDType.php

4 lines

differential/

phid/

DifferentialDiffPHIDType.php

4 lines

85%

DifferentialRevisionPHIDType.php

8 lines

drydock/

phid/

DrydockAuthorizationPHIDType.php

4 lines

21%

DrydockBlueprintPHIDType.php

8 lines

17%

DrydockLeasePHIDType.php

8 lines

17%

DrydockRepositoryOperationPHIDType.php

4 lines

21%

DrydockResourcePHIDType.php

8 lines

15%

files/

phid/

PhabricatorFileFilePHIDType.php

4 lines

fund/

phid/

FundBackerPHIDType.php

4 lines

17%

harbormaster/

phid/

HarbormasterBuildArtifactPHIDType.php

4 lines

23%

HarbormasterBuildLogPHIDType.php

4 lines

27%

HarbormasterBuildPHIDType.php

4 lines

33%

HarbormasterBuildPlanPHIDType.php

4 lines

33%

HarbormasterBuildStepPHIDType.php

4 lines

18%

HarbormasterBuildTargetPHIDType.php

4 lines

17%

HarbormasterBuildablePHIDType.php

4 lines

17%

herald/

phid/

HeraldRulePHIDType.php

4 lines

legalpad/

phid/

PhabricatorLegalpadDocumentPHIDType.php

4 lines

maniphest/

phid/

ManiphestTaskPHIDType.php

8 lines

11%

meta/

phid/

PhabricatorApplicationApplicationPHIDType.php

4 lines

21%

metamta/

phid/

PhabricatorMetaMTAMailPHIDType.php

8 lines

20%

nuance/

phid/

NuanceItemPHIDType.php

4 lines

21%

NuanceQueuePHIDType.php

4 lines

21%

NuanceRequestorPHIDType.php

4 lines

21%

NuanceSourcePHIDType.php

4 lines

21%

oauthserver/

phid/

PhabricatorOAuthServerClientAuthorizationPHIDType.php

4 lines

25%

PhabricatorOAuthServerClientPHIDType.php

4 lines

25%

owners/

phid/

PhabricatorOwnersPackagePHIDType.php

4 lines

18%

paste/

phid/

PhabricatorPastePastePHIDType.php

4 lines

people/

phid/

PhabricatorPeopleExternalPHIDType.php

4 lines

23%

PhabricatorPeopleUserPHIDType.php

8 lines

phame/

phid/

PhabricatorPhameBlogPHIDType.php

4 lines

21%

PhabricatorPhamePostPHIDType.php

4 lines

21%

phid/

PhabricatorMetaMTAApplicationEmailPHIDType.php

8 lines

21%

type/

PhabricatorPHIDType.php

15 lines

27%

__tests__/

PhabricatorPHIDTypeTestCase.php

12 lines

100%

phlux/

phid/

PhluxVariablePHIDType.php

4 lines

20%

pholio/

phid/

PholioImagePHIDType.php

4 lines

17%

PholioMockPHIDType.php

8 lines

phortune/

phid/

PhortuneAccountPHIDType.php

4 lines

21%

PhortuneCartPHIDType.php

4 lines

20%

PhortuneChargePHIDType.php

4 lines

21%

PhortuneMerchantPHIDType.php

4 lines

21%

PhortunePaymentMethodPHIDType.php

4 lines

23%

PhortunePaymentProviderPHIDType.php

4 lines

23%

PhortuneProductPHIDType.php

4 lines

21%

PhortunePurchasePHIDType.php

4 lines

21%

PhortuneSubscriptionPHIDType.php

4 lines

21%

phragment/

phid/

PhragmentFragmentPHIDType.php

4 lines

17%

PhragmentFragmentVersionPHIDType.php

4 lines

17%

PhragmentSnapshotPHIDType.php

4 lines

18%

phriction/

phid/

PhrictionDocumentPHIDType.php

8 lines

14%

phurl/

phid/

PhabricatorPhurlURLPHIDType.php

8 lines

policy/

phid/

PhabricatorPolicyPHIDTypePolicy.php

4 lines

23%

ponder/

phid/

PonderQuestionPHIDType.php

8 lines

project/

phid/

PhabricatorProjectColumnPHIDType.php

8 lines

17%

PhabricatorProjectProjectPHIDType.php

8 lines

releeph/

phid/

ReleephBranchPHIDType.php

4 lines

21%

ReleephProductPHIDType.php

4 lines

23%

ReleephRequestPHIDType.php

4 lines

18%

repository/

phid/

PhabricatorRepositoryCommitPHIDType.php

8 lines

PhabricatorRepositoryMirrorPHIDType.php

4 lines

21%

PhabricatorRepositoryPushEventPHIDType.php

4 lines

25%

PhabricatorRepositoryPushLogPHIDType.php

4 lines

25%

PhabricatorRepositoryRepositoryPHIDType.php

4 lines

slowvote/

phid/

PhabricatorSlowvotePollPHIDType.php

4 lines

spaces/

phid/

PhabricatorSpacesNamespacePHIDType.php

8 lines

11%

tokens/

phid/

PhabricatorTokenTokenPHIDType.php

4 lines

23%

transactions/

phid/

PhabricatorApplicationTransactionTransactionPHIDType.php

4 lines

infrastructure/

daemon/

workers/

phid/

PhabricatorWorkerBulkJobPHIDType.php

4 lines

23%

PhabricatorWorkerTriggerPHIDType.php

4 lines

23%

Diff 34725

View Options

src/applications/almanac/phid/AlmanacBindingPHIDType.php

View Options

src/applications/almanac/phid/AlmanacDevicePHIDType.php

View Options

src/applications/almanac/phid/AlmanacInterfacePHIDType.php

View Options

src/applications/almanac/phid/AlmanacNetworkPHIDType.php

View Options

src/applications/almanac/phid/AlmanacServicePHIDType.php

View Options

src/applications/auth/phid/PhabricatorAuthAuthFactorPHIDType.php

View Options

src/applications/auth/phid/PhabricatorAuthAuthProviderPHIDType.php

View Options

src/applications/auth/phid/PhabricatorAuthInvitePHIDType.php

View Options

src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php

View Options

src/applications/config/phid/PhabricatorConfigConfigPHIDType.php

View Options

src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php

View Options

src/applications/dashboard/phid/PhabricatorDashboardDashboardPHIDType.php

View Options

src/applications/dashboard/phid/PhabricatorDashboardPanelPHIDType.php

View Options

src/applications/differential/phid/DifferentialDiffPHIDType.php

View Options

src/applications/differential/phid/DifferentialRevisionPHIDType.php

View Options

src/applications/drydock/phid/DrydockAuthorizationPHIDType.php

View Options

src/applications/drydock/phid/DrydockBlueprintPHIDType.php

View Options

src/applications/drydock/phid/DrydockLeasePHIDType.php

View Options

src/applications/drydock/phid/DrydockRepositoryOperationPHIDType.php

View Options

src/applications/drydock/phid/DrydockResourcePHIDType.php

View Options

src/applications/files/phid/PhabricatorFileFilePHIDType.php

View Options

src/applications/fund/phid/FundBackerPHIDType.php

View Options

src/applications/harbormaster/phid/HarbormasterBuildArtifactPHIDType.php

View Options

src/applications/harbormaster/phid/HarbormasterBuildLogPHIDType.php

View Options

src/applications/harbormaster/phid/HarbormasterBuildPHIDType.php

View Options

src/applications/harbormaster/phid/HarbormasterBuildPlanPHIDType.php

View Options

src/applications/harbormaster/phid/HarbormasterBuildStepPHIDType.php

View Options

src/applications/harbormaster/phid/HarbormasterBuildTargetPHIDType.php

View Options

src/applications/harbormaster/phid/HarbormasterBuildablePHIDType.php

View Options

src/applications/herald/phid/HeraldRulePHIDType.php

View Options

src/applications/legalpad/phid/PhabricatorLegalpadDocumentPHIDType.php

View Options

src/applications/maniphest/phid/ManiphestTaskPHIDType.php

View Options

src/applications/meta/phid/PhabricatorApplicationApplicationPHIDType.php

View Options

src/applications/metamta/phid/PhabricatorMetaMTAMailPHIDType.php

View Options

src/applications/nuance/phid/NuanceItemPHIDType.php

View Options

src/applications/nuance/phid/NuanceQueuePHIDType.php

View Options

src/applications/nuance/phid/NuanceRequestorPHIDType.php

View Options

src/applications/nuance/phid/NuanceSourcePHIDType.php

View Options

src/applications/oauthserver/phid/PhabricatorOAuthServerClientAuthorizationPHIDType.php

View Options

src/applications/oauthserver/phid/PhabricatorOAuthServerClientPHIDType.php

View Options

src/applications/owners/phid/PhabricatorOwnersPackagePHIDType.php

View Options

src/applications/paste/phid/PhabricatorPastePastePHIDType.php

View Options

src/applications/people/phid/PhabricatorPeopleExternalPHIDType.php

View Options

src/applications/people/phid/PhabricatorPeopleUserPHIDType.php

View Options

src/applications/phame/phid/PhabricatorPhameBlogPHIDType.php

View Options

src/applications/phame/phid/PhabricatorPhamePostPHIDType.php

View Options

src/applications/phid/PhabricatorMetaMTAApplicationEmailPHIDType.php

View Options

src/applications/phid/type/PhabricatorPHIDType.php

View Options

src/applications/phid/type/tests/PhabricatorPHIDTypeTestCase.php

View Options

src/applications/phlux/phid/PhluxVariablePHIDType.php

View Options

src/applications/pholio/phid/PholioImagePHIDType.php

View Options

src/applications/pholio/phid/PholioMockPHIDType.php

View Options

src/applications/phortune/phid/PhortuneAccountPHIDType.php

View Options

src/applications/phortune/phid/PhortuneCartPHIDType.php

View Options

src/applications/phortune/phid/PhortuneChargePHIDType.php

View Options

src/applications/phortune/phid/PhortuneMerchantPHIDType.php

View Options

src/applications/phortune/phid/PhortunePaymentMethodPHIDType.php

View Options

src/applications/phortune/phid/PhortunePaymentProviderPHIDType.php

View Options

src/applications/phortune/phid/PhortuneProductPHIDType.php

View Options

src/applications/phortune/phid/PhortunePurchasePHIDType.php

View Options

src/applications/phortune/phid/PhortuneSubscriptionPHIDType.php

View Options

src/applications/phragment/phid/PhragmentFragmentPHIDType.php

View Options

src/applications/phragment/phid/PhragmentFragmentVersionPHIDType.php

View Options

src/applications/phragment/phid/PhragmentSnapshotPHIDType.php

View Options

src/applications/phriction/phid/PhrictionDocumentPHIDType.php

View Options

src/applications/phurl/phid/PhabricatorPhurlURLPHIDType.php

View Options

src/applications/policy/phid/PhabricatorPolicyPHIDTypePolicy.php

View Options

src/applications/ponder/phid/PonderQuestionPHIDType.php

View Options

src/applications/project/phid/PhabricatorProjectColumnPHIDType.php

View Options

src/applications/project/phid/PhabricatorProjectProjectPHIDType.php

View Options

src/applications/releeph/phid/ReleephBranchPHIDType.php

View Options

src/applications/releeph/phid/ReleephProductPHIDType.php

View Options

src/applications/releeph/phid/ReleephRequestPHIDType.php

View Options

src/applications/repository/phid/PhabricatorRepositoryCommitPHIDType.php

View Options

src/applications/repository/phid/PhabricatorRepositoryMirrorPHIDType.php

View Options

src/applications/repository/phid/PhabricatorRepositoryPushEventPHIDType.php

View Options

src/applications/repository/phid/PhabricatorRepositoryPushLogPHIDType.php

View Options

src/applications/repository/phid/PhabricatorRepositoryRepositoryPHIDType.php

View Options

src/applications/slowvote/phid/PhabricatorSlowvotePollPHIDType.php

View Options

src/applications/spaces/phid/PhabricatorSpacesNamespacePHIDType.php

View Options

src/applications/tokens/phid/PhabricatorTokenTokenPHIDType.php

View Options

src/applications/transactions/phid/PhabricatorApplicationTransactionTransactionPHIDType.php

View Options

src/infrastructure/daemon/workers/phid/PhabricatorWorkerBulkJobPHIDType.php

View Options

src/infrastructure/daemon/workers/phid/PhabricatorWorkerTriggerPHIDType.php

Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstractClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34725

src/applications/almanac/phid/AlmanacBindingPHIDType.php

src/applications/almanac/phid/AlmanacDevicePHIDType.php

src/applications/almanac/phid/AlmanacInterfacePHIDType.php

src/applications/almanac/phid/AlmanacNetworkPHIDType.php

src/applications/almanac/phid/AlmanacServicePHIDType.php

src/applications/auth/phid/PhabricatorAuthAuthFactorPHIDType.php

src/applications/auth/phid/PhabricatorAuthAuthProviderPHIDType.php

src/applications/auth/phid/PhabricatorAuthInvitePHIDType.php

src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php

src/applications/config/phid/PhabricatorConfigConfigPHIDType.php

src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php

src/applications/dashboard/phid/PhabricatorDashboardDashboardPHIDType.php

src/applications/dashboard/phid/PhabricatorDashboardPanelPHIDType.php

src/applications/differential/phid/DifferentialDiffPHIDType.php

src/applications/differential/phid/DifferentialRevisionPHIDType.php

src/applications/drydock/phid/DrydockAuthorizationPHIDType.php

src/applications/drydock/phid/DrydockBlueprintPHIDType.php

src/applications/drydock/phid/DrydockLeasePHIDType.php

src/applications/drydock/phid/DrydockRepositoryOperationPHIDType.php

src/applications/drydock/phid/DrydockResourcePHIDType.php

src/applications/files/phid/PhabricatorFileFilePHIDType.php

src/applications/fund/phid/FundBackerPHIDType.php

src/applications/harbormaster/phid/HarbormasterBuildArtifactPHIDType.php

src/applications/harbormaster/phid/HarbormasterBuildLogPHIDType.php

src/applications/harbormaster/phid/HarbormasterBuildPHIDType.php

src/applications/harbormaster/phid/HarbormasterBuildPlanPHIDType.php

src/applications/harbormaster/phid/HarbormasterBuildStepPHIDType.php

src/applications/harbormaster/phid/HarbormasterBuildTargetPHIDType.php

src/applications/harbormaster/phid/HarbormasterBuildablePHIDType.php

src/applications/herald/phid/HeraldRulePHIDType.php

src/applications/legalpad/phid/PhabricatorLegalpadDocumentPHIDType.php

src/applications/maniphest/phid/ManiphestTaskPHIDType.php

src/applications/meta/phid/PhabricatorApplicationApplicationPHIDType.php

src/applications/metamta/phid/PhabricatorMetaMTAMailPHIDType.php

src/applications/nuance/phid/NuanceItemPHIDType.php

src/applications/nuance/phid/NuanceQueuePHIDType.php

src/applications/nuance/phid/NuanceRequestorPHIDType.php

src/applications/nuance/phid/NuanceSourcePHIDType.php

src/applications/oauthserver/phid/PhabricatorOAuthServerClientAuthorizationPHIDType.php

src/applications/oauthserver/phid/PhabricatorOAuthServerClientPHIDType.php

src/applications/owners/phid/PhabricatorOwnersPackagePHIDType.php

src/applications/paste/phid/PhabricatorPastePastePHIDType.php

src/applications/people/phid/PhabricatorPeopleExternalPHIDType.php

src/applications/people/phid/PhabricatorPeopleUserPHIDType.php

src/applications/phame/phid/PhabricatorPhameBlogPHIDType.php

src/applications/phame/phid/PhabricatorPhamePostPHIDType.php

src/applications/phid/PhabricatorMetaMTAApplicationEmailPHIDType.php

src/applications/phid/type/PhabricatorPHIDType.php

src/applications/phid/type/__tests__/PhabricatorPHIDTypeTestCase.php

src/applications/phlux/phid/PhluxVariablePHIDType.php

src/applications/pholio/phid/PholioImagePHIDType.php

src/applications/pholio/phid/PholioMockPHIDType.php

src/applications/phortune/phid/PhortuneAccountPHIDType.php

src/applications/phortune/phid/PhortuneCartPHIDType.php

src/applications/phortune/phid/PhortuneChargePHIDType.php

src/applications/phortune/phid/PhortuneMerchantPHIDType.php

src/applications/phortune/phid/PhortunePaymentMethodPHIDType.php

src/applications/phortune/phid/PhortunePaymentProviderPHIDType.php

src/applications/phortune/phid/PhortuneProductPHIDType.php

src/applications/phortune/phid/PhortunePurchasePHIDType.php

src/applications/phortune/phid/PhortuneSubscriptionPHIDType.php

src/applications/phragment/phid/PhragmentFragmentPHIDType.php

src/applications/phragment/phid/PhragmentFragmentVersionPHIDType.php

src/applications/phragment/phid/PhragmentSnapshotPHIDType.php

src/applications/phriction/phid/PhrictionDocumentPHIDType.php

src/applications/phurl/phid/PhabricatorPhurlURLPHIDType.php

src/applications/policy/phid/PhabricatorPolicyPHIDTypePolicy.php

src/applications/ponder/phid/PonderQuestionPHIDType.php

src/applications/project/phid/PhabricatorProjectColumnPHIDType.php

src/applications/project/phid/PhabricatorProjectProjectPHIDType.php

src/applications/releeph/phid/ReleephBranchPHIDType.php

src/applications/releeph/phid/ReleephProductPHIDType.php

src/applications/releeph/phid/ReleephRequestPHIDType.php

src/applications/repository/phid/PhabricatorRepositoryCommitPHIDType.php

Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/phid/type/tests/PhabricatorPHIDTypeTestCase.php