Paths

Table of Contentst

Diffusion Phabricator 495cb7a2e037

Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract
495cb7a2e037
Actions

Description

Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract

Summary: Fixes T9625. As explained in a TODO comment, seems reasonable enough.

Test Plan: Unit tests.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: Korvin, hach-que

Maniphest Tasks: T9625

Differential Revision: https://secure.phabricator.com/D14068

Details

Provenance

joshuaspence	Authored on
joshuaspence	Pushed on Nov 2 2015, 7:47 PM

Reviewer

Blessed Reviewers

Differential Revision

D14068: Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract

Parents

rP09d4ea884fe4: Ref T8989, Add a "Visit URL" link to Phurl items.

Branches

Unknown

Tags

Unknown

Tasks

T9625: Fill in missing applications and icons on PHID types

Build Status

Buildable 8544
Build 9860: Run Core Tests

Event Timeline

joshuaspence committed rP495cb7a2e037: Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract (authored by joshuaspence).Nov 2 2015, 7:47 PM

joshuaspence added a task: T9625: Fill in missing applications and icons on PHID types.

Harbormaster completed building B8544: rP495cb7a2e037: Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract.Nov 2 2015, 7:48 PM

Changes (84)

Path

Size

src/

applications/

almanac/

phid/

AlmanacBindingPHIDType.php

AlmanacDevicePHIDType.php

AlmanacInterfacePHIDType.php

AlmanacNetworkPHIDType.php

AlmanacServicePHIDType.php

auth/

phid/

PhabricatorAuthAuthFactorPHIDType.php

PhabricatorAuthAuthProviderPHIDType.php

PhabricatorAuthInvitePHIDType.php

calendar/

phid/

PhabricatorCalendarEventPHIDType.php

config/

phid/

PhabricatorConfigConfigPHIDType.php

countdown/

phid/

PhabricatorCountdownCountdownPHIDType.php

dashboard/

phid/

PhabricatorDashboardDashboardPHIDType.php

PhabricatorDashboardPanelPHIDType.php

differential/

phid/

DifferentialDiffPHIDType.php

DifferentialRevisionPHIDType.php

drydock/

phid/

DrydockAuthorizationPHIDType.php

DrydockBlueprintPHIDType.php

DrydockLeasePHIDType.php

DrydockRepositoryOperationPHIDType.php

DrydockResourcePHIDType.php

files/

phid/

PhabricatorFileFilePHIDType.php

fund/

phid/

FundBackerPHIDType.php

harbormaster/

phid/

HarbormasterBuildArtifactPHIDType.php

HarbormasterBuildLogPHIDType.php

HarbormasterBuildPHIDType.php

HarbormasterBuildPlanPHIDType.php

HarbormasterBuildStepPHIDType.php

HarbormasterBuildTargetPHIDType.php

HarbormasterBuildablePHIDType.php

herald/

phid/

HeraldRulePHIDType.php

legalpad/

phid/

PhabricatorLegalpadDocumentPHIDType.php

maniphest/

phid/

ManiphestTaskPHIDType.php

meta/

phid/

PhabricatorApplicationApplicationPHIDType.php

metamta/

phid/

PhabricatorMetaMTAMailPHIDType.php

nuance/

phid/

NuanceItemPHIDType.php

NuanceQueuePHIDType.php

NuanceRequestorPHIDType.php

NuanceSourcePHIDType.php

oauthserver/

phid/

PhabricatorOAuthServerClientAuthorizationPHIDType.php

PhabricatorOAuthServerClientPHIDType.php

owners/

phid/

PhabricatorOwnersPackagePHIDType.php

paste/

phid/

PhabricatorPastePastePHIDType.php

people/

phid/

PhabricatorPeopleExternalPHIDType.php

PhabricatorPeopleUserPHIDType.php

phame/

phid/

PhabricatorPhameBlogPHIDType.php

PhabricatorPhamePostPHIDType.php

phid/

PhabricatorMetaMTAApplicationEmailPHIDType.php

type/

PhabricatorPHIDType.php

__tests__/

PhabricatorPHIDTypeTestCase.php

phlux/

phid/

PhluxVariablePHIDType.php

pholio/

phid/

PholioImagePHIDType.php

PholioMockPHIDType.php

phortune/

phid/

PhortuneAccountPHIDType.php

PhortuneCartPHIDType.php

PhortuneChargePHIDType.php

PhortuneMerchantPHIDType.php

PhortunePaymentMethodPHIDType.php

PhortunePaymentProviderPHIDType.php

PhortuneProductPHIDType.php

PhortunePurchasePHIDType.php

PhortuneSubscriptionPHIDType.php

phragment/

phid/

PhragmentFragmentPHIDType.php

PhragmentFragmentVersionPHIDType.php

PhragmentSnapshotPHIDType.php

phriction/

phid/

PhrictionDocumentPHIDType.php

phurl/

phid/

PhabricatorPhurlURLPHIDType.php

policy/

phid/

PhabricatorPolicyPHIDTypePolicy.php

ponder/

phid/

PonderQuestionPHIDType.php

project/

phid/

PhabricatorProjectColumnPHIDType.php

PhabricatorProjectProjectPHIDType.php

releeph/

phid/

ReleephBranchPHIDType.php

ReleephProductPHIDType.php

ReleephRequestPHIDType.php

repository/

phid/

PhabricatorRepositoryCommitPHIDType.php

PhabricatorRepositoryMirrorPHIDType.php

PhabricatorRepositoryPushEventPHIDType.php

PhabricatorRepositoryPushLogPHIDType.php

PhabricatorRepositoryRepositoryPHIDType.php

slowvote/

phid/

PhabricatorSlowvotePollPHIDType.php

spaces/

phid/

PhabricatorSpacesNamespacePHIDType.php

tokens/

phid/

PhabricatorTokenTokenPHIDType.php

transactions/

phid/

PhabricatorApplicationTransactionTransactionPHIDType.php

infrastructure/

daemon/

workers/

phid/

PhabricatorWorkerBulkJobPHIDType.php

PhabricatorWorkerTriggerPHIDType.php

rP495cb7a2e037

View Options

src/applications/almanac/phid/AlmanacBindingPHIDType.php

View Options

src/applications/almanac/phid/AlmanacDevicePHIDType.php

View Options

src/applications/almanac/phid/AlmanacInterfacePHIDType.php

View Options

src/applications/almanac/phid/AlmanacNetworkPHIDType.php

View Options

src/applications/almanac/phid/AlmanacServicePHIDType.php

View Options

src/applications/auth/phid/PhabricatorAuthAuthFactorPHIDType.php

View Options

src/applications/auth/phid/PhabricatorAuthAuthProviderPHIDType.php

View Options

src/applications/auth/phid/PhabricatorAuthInvitePHIDType.php

View Options

src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php

View Options

src/applications/config/phid/PhabricatorConfigConfigPHIDType.php

View Options

src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php

View Options

src/applications/dashboard/phid/PhabricatorDashboardDashboardPHIDType.php

View Options

src/applications/dashboard/phid/PhabricatorDashboardPanelPHIDType.php

View Options

src/applications/differential/phid/DifferentialDiffPHIDType.php

View Options

src/applications/differential/phid/DifferentialRevisionPHIDType.php

View Options

src/applications/drydock/phid/DrydockAuthorizationPHIDType.php

View Options

src/applications/drydock/phid/DrydockBlueprintPHIDType.php

View Options

src/applications/drydock/phid/DrydockLeasePHIDType.php

View Options

src/applications/drydock/phid/DrydockRepositoryOperationPHIDType.php

View Options

src/applications/drydock/phid/DrydockResourcePHIDType.php

View Options

src/applications/files/phid/PhabricatorFileFilePHIDType.php

View Options

src/applications/fund/phid/FundBackerPHIDType.php

View Options

src/applications/harbormaster/phid/HarbormasterBuildArtifactPHIDType.php

View Options

src/applications/harbormaster/phid/HarbormasterBuildLogPHIDType.php

View Options

src/applications/harbormaster/phid/HarbormasterBuildPHIDType.php

View Options

src/applications/harbormaster/phid/HarbormasterBuildPlanPHIDType.php

View Options

src/applications/harbormaster/phid/HarbormasterBuildStepPHIDType.php

View Options

src/applications/harbormaster/phid/HarbormasterBuildTargetPHIDType.php

View Options

src/applications/harbormaster/phid/HarbormasterBuildablePHIDType.php

View Options

src/applications/herald/phid/HeraldRulePHIDType.php

View Options

src/applications/legalpad/phid/PhabricatorLegalpadDocumentPHIDType.php

View Options

src/applications/maniphest/phid/ManiphestTaskPHIDType.php

View Options

src/applications/meta/phid/PhabricatorApplicationApplicationPHIDType.php

View Options

src/applications/metamta/phid/PhabricatorMetaMTAMailPHIDType.php

View Options

src/applications/nuance/phid/NuanceItemPHIDType.php

View Options

src/applications/nuance/phid/NuanceQueuePHIDType.php

View Options

src/applications/nuance/phid/NuanceRequestorPHIDType.php

View Options

src/applications/nuance/phid/NuanceSourcePHIDType.php

View Options

src/applications/oauthserver/phid/PhabricatorOAuthServerClientAuthorizationPHIDType.php

View Options

src/applications/oauthserver/phid/PhabricatorOAuthServerClientPHIDType.php

View Options

src/applications/owners/phid/PhabricatorOwnersPackagePHIDType.php

View Options

src/applications/paste/phid/PhabricatorPastePastePHIDType.php

View Options

src/applications/people/phid/PhabricatorPeopleExternalPHIDType.php

View Options

src/applications/people/phid/PhabricatorPeopleUserPHIDType.php

View Options

src/applications/phame/phid/PhabricatorPhameBlogPHIDType.php

View Options

src/applications/phame/phid/PhabricatorPhamePostPHIDType.php

View Options

src/applications/phid/PhabricatorMetaMTAApplicationEmailPHIDType.php

View Options

src/applications/phid/type/PhabricatorPHIDType.php

View Options

src/applications/phid/type/tests/PhabricatorPHIDTypeTestCase.php

View Options

src/applications/phlux/phid/PhluxVariablePHIDType.php

View Options

src/applications/pholio/phid/PholioImagePHIDType.php

View Options

src/applications/pholio/phid/PholioMockPHIDType.php

View Options

src/applications/phortune/phid/PhortuneAccountPHIDType.php

View Options

src/applications/phortune/phid/PhortuneCartPHIDType.php

View Options

src/applications/phortune/phid/PhortuneChargePHIDType.php

View Options

src/applications/phortune/phid/PhortuneMerchantPHIDType.php

View Options

src/applications/phortune/phid/PhortunePaymentMethodPHIDType.php

View Options

src/applications/phortune/phid/PhortunePaymentProviderPHIDType.php

View Options

src/applications/phortune/phid/PhortuneProductPHIDType.php

View Options

src/applications/phortune/phid/PhortunePurchasePHIDType.php

View Options

src/applications/phortune/phid/PhortuneSubscriptionPHIDType.php

View Options

src/applications/phragment/phid/PhragmentFragmentPHIDType.php

View Options

src/applications/phragment/phid/PhragmentFragmentVersionPHIDType.php

View Options

src/applications/phragment/phid/PhragmentSnapshotPHIDType.php

View Options

src/applications/phriction/phid/PhrictionDocumentPHIDType.php

View Options

src/applications/phurl/phid/PhabricatorPhurlURLPHIDType.php

View Options

src/applications/policy/phid/PhabricatorPolicyPHIDTypePolicy.php

View Options

src/applications/ponder/phid/PonderQuestionPHIDType.php

View Options

src/applications/project/phid/PhabricatorProjectColumnPHIDType.php

View Options

src/applications/project/phid/PhabricatorProjectProjectPHIDType.php

View Options

src/applications/releeph/phid/ReleephBranchPHIDType.php

View Options

src/applications/releeph/phid/ReleephProductPHIDType.php

View Options

src/applications/releeph/phid/ReleephRequestPHIDType.php

View Options

src/applications/repository/phid/PhabricatorRepositoryCommitPHIDType.php

View Options

src/applications/repository/phid/PhabricatorRepositoryMirrorPHIDType.php

View Options

src/applications/repository/phid/PhabricatorRepositoryPushEventPHIDType.php

View Options

src/applications/repository/phid/PhabricatorRepositoryPushLogPHIDType.php

View Options

src/applications/repository/phid/PhabricatorRepositoryRepositoryPHIDType.php

View Options

src/applications/slowvote/phid/PhabricatorSlowvotePollPHIDType.php

View Options

src/applications/spaces/phid/PhabricatorSpacesNamespacePHIDType.php

View Options

src/applications/tokens/phid/PhabricatorTokenTokenPHIDType.php

View Options

src/applications/transactions/phid/PhabricatorApplicationTransactionTransactionPHIDType.php

View Options

src/infrastructure/daemon/workers/phid/PhabricatorWorkerBulkJobPHIDType.php

View Options

src/infrastructure/daemon/workers/phid/PhabricatorWorkerTriggerPHIDType.php

Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract495cb7a2e037Actions

Description

Details

Event Timeline

Changes (84)

rP495cb7a2e037

src/applications/almanac/phid/AlmanacBindingPHIDType.php

src/applications/almanac/phid/AlmanacDevicePHIDType.php

src/applications/almanac/phid/AlmanacInterfacePHIDType.php

src/applications/almanac/phid/AlmanacNetworkPHIDType.php

src/applications/almanac/phid/AlmanacServicePHIDType.php

src/applications/auth/phid/PhabricatorAuthAuthFactorPHIDType.php

src/applications/auth/phid/PhabricatorAuthAuthProviderPHIDType.php

src/applications/auth/phid/PhabricatorAuthInvitePHIDType.php

src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php

src/applications/config/phid/PhabricatorConfigConfigPHIDType.php

src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php

src/applications/dashboard/phid/PhabricatorDashboardDashboardPHIDType.php

src/applications/dashboard/phid/PhabricatorDashboardPanelPHIDType.php

src/applications/differential/phid/DifferentialDiffPHIDType.php

src/applications/differential/phid/DifferentialRevisionPHIDType.php

src/applications/drydock/phid/DrydockAuthorizationPHIDType.php

src/applications/drydock/phid/DrydockBlueprintPHIDType.php

src/applications/drydock/phid/DrydockLeasePHIDType.php

src/applications/drydock/phid/DrydockRepositoryOperationPHIDType.php

src/applications/drydock/phid/DrydockResourcePHIDType.php

src/applications/files/phid/PhabricatorFileFilePHIDType.php

src/applications/fund/phid/FundBackerPHIDType.php

src/applications/harbormaster/phid/HarbormasterBuildArtifactPHIDType.php

src/applications/harbormaster/phid/HarbormasterBuildLogPHIDType.php

src/applications/harbormaster/phid/HarbormasterBuildPHIDType.php

src/applications/harbormaster/phid/HarbormasterBuildPlanPHIDType.php

src/applications/harbormaster/phid/HarbormasterBuildStepPHIDType.php

src/applications/harbormaster/phid/HarbormasterBuildTargetPHIDType.php

src/applications/harbormaster/phid/HarbormasterBuildablePHIDType.php

src/applications/herald/phid/HeraldRulePHIDType.php

src/applications/legalpad/phid/PhabricatorLegalpadDocumentPHIDType.php

src/applications/maniphest/phid/ManiphestTaskPHIDType.php

src/applications/meta/phid/PhabricatorApplicationApplicationPHIDType.php

src/applications/metamta/phid/PhabricatorMetaMTAMailPHIDType.php

src/applications/nuance/phid/NuanceItemPHIDType.php

src/applications/nuance/phid/NuanceQueuePHIDType.php

src/applications/nuance/phid/NuanceRequestorPHIDType.php

src/applications/nuance/phid/NuanceSourcePHIDType.php

src/applications/oauthserver/phid/PhabricatorOAuthServerClientAuthorizationPHIDType.php

src/applications/oauthserver/phid/PhabricatorOAuthServerClientPHIDType.php

src/applications/owners/phid/PhabricatorOwnersPackagePHIDType.php

src/applications/paste/phid/PhabricatorPastePastePHIDType.php

src/applications/people/phid/PhabricatorPeopleExternalPHIDType.php

src/applications/people/phid/PhabricatorPeopleUserPHIDType.php

src/applications/phame/phid/PhabricatorPhameBlogPHIDType.php

src/applications/phame/phid/PhabricatorPhamePostPHIDType.php

src/applications/phid/PhabricatorMetaMTAApplicationEmailPHIDType.php

src/applications/phid/type/PhabricatorPHIDType.php

src/applications/phid/type/__tests__/PhabricatorPHIDTypeTestCase.php

src/applications/phlux/phid/PhluxVariablePHIDType.php

src/applications/pholio/phid/PholioImagePHIDType.php

src/applications/pholio/phid/PholioMockPHIDType.php

src/applications/phortune/phid/PhortuneAccountPHIDType.php

src/applications/phortune/phid/PhortuneCartPHIDType.php

src/applications/phortune/phid/PhortuneChargePHIDType.php

src/applications/phortune/phid/PhortuneMerchantPHIDType.php

src/applications/phortune/phid/PhortunePaymentMethodPHIDType.php

src/applications/phortune/phid/PhortunePaymentProviderPHIDType.php

src/applications/phortune/phid/PhortuneProductPHIDType.php

src/applications/phortune/phid/PhortunePurchasePHIDType.php

src/applications/phortune/phid/PhortuneSubscriptionPHIDType.php

src/applications/phragment/phid/PhragmentFragmentPHIDType.php

src/applications/phragment/phid/PhragmentFragmentVersionPHIDType.php

src/applications/phragment/phid/PhragmentSnapshotPHIDType.php

src/applications/phriction/phid/PhrictionDocumentPHIDType.php

src/applications/phurl/phid/PhabricatorPhurlURLPHIDType.php

src/applications/policy/phid/PhabricatorPolicyPHIDTypePolicy.php

src/applications/ponder/phid/PonderQuestionPHIDType.php

src/applications/project/phid/PhabricatorProjectColumnPHIDType.php

src/applications/project/phid/PhabricatorProjectProjectPHIDType.php

src/applications/releeph/phid/ReleephBranchPHIDType.php

src/applications/releeph/phid/ReleephProductPHIDType.php

src/applications/releeph/phid/ReleephRequestPHIDType.php

src/applications/repository/phid/PhabricatorRepositoryCommitPHIDType.php

Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract
495cb7a2e037
Actions

src/applications/phid/type/tests/PhabricatorPHIDTypeTestCase.php