Page MenuHomePhabricator

Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract
ClosedPublic

Authored by joshuaspence on Sep 6 2015, 3:58 AM.
Tags
None
Referenced Files
F12834846: D14068.id34008.diff
Thu, Mar 28, 2:50 PM
Unknown Object (File)
Tue, Mar 26, 3:48 AM
Unknown Object (File)
Feb 13 2024, 5:12 PM
Unknown Object (File)
Feb 12 2024, 12:52 PM
Unknown Object (File)
Feb 11 2024, 8:05 AM
Unknown Object (File)
Feb 9 2024, 5:00 PM
Unknown Object (File)
Feb 2 2024, 10:54 AM
Unknown Object (File)
Jan 28 2024, 4:29 PM
Subscribers

Details

Summary

Fixes T9625. As explained in a TODO comment, seems reasonable enough.

Test Plan

Unit tests.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7925
Build 8879: [Placeholder Plan] Wait for 30 Seconds
Build 8878: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

(I vaguely wonder if we should have a PhabricatorWhateverApplication::APPCONST sort of constant, mostly to get better static analyzability, but that's easy to add later.)

This revision is now accepted and ready to land.Sep 6 2015, 2:58 PM
This revision was automatically updated to reflect the committed changes.