Page MenuHomePhabricator

Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract
ClosedPublic

Authored by joshuaspence on Sep 6 2015, 3:58 AM.
Tags
None
Referenced Files
F15504183: D14068.id34725.diff
Mon, Apr 14, 4:33 PM
F15463635: D14068.id34008.diff
Wed, Apr 2, 1:44 AM
F15463420: D14068.id.diff
Tue, Apr 1, 11:17 PM
F15463228: D14068.id34008.diff
Tue, Apr 1, 9:35 PM
F15460099: D14068.diff
Mon, Mar 31, 8:07 PM
F15428640: D14068.id34008.diff
Mar 23 2025, 9:26 PM
F15412013: D14068.id34734.diff
Mar 19 2025, 10:51 AM
F15383904: D14068.diff
Mar 14 2025, 6:18 PM
Subscribers

Details

Summary

Fixes T9625. As explained in a TODO comment, seems reasonable enough.

Test Plan

Unit tests.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7925
Build 8879: [Placeholder Plan] Wait for 30 Seconds
Build 8878: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

(I vaguely wonder if we should have a PhabricatorWhateverApplication::APPCONST sort of constant, mostly to get better static analyzability, but that's easy to add later.)

This revision is now accepted and ready to land.Sep 6 2015, 2:58 PM
This revision was automatically updated to reflect the committed changes.