Paths

Table of Contentst

Differential D13974

Fix bison warnings
ClosedPublic
Actions

Authored by joshuaspence on Aug 23 2015, 8:12 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU5a0b680c82eb: Fix bison warnings

Summary

Fix a bunch of bison warnings without affecting XHPAST functionality. Depends on D13970.

Test Plan

Compared the MD5 hash of support/xhpast/xhpast before and after this change.

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7736
Build 8505: [Placeholder Plan] Wait for 30 Seconds
Build 8504: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33714.Aug 23 2015, 8:12 AM

joshuaspence retitled this revision from to Fix bison warnings.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D13970: Enable bison warnings.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 23 2015, 8:12 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Aug 23 2015, 2:07 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 23 2015, 2:07 PM

Closed by commit rPHU5a0b680c82eb: Fix bison warnings (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 27 2015, 12:18 PM

This revision was automatically updated to reflect the committed changes.

• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM

chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

epriestley mentioned this in T9753: XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3).Nov 10 2015, 2:46 PM

epriestley mentioned this in T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5.Apr 7 2020, 2:08 PM

epriestley mentioned this in D21063: Revert xhpast changes that impacted builds under Bison 2.3.Apr 7 2020, 9:02 PM

epriestley mentioned this in rARC763ac445dc8d: Revert xhpast changes that impacted builds under Bison 2.3.Apr 7 2020, 9:29 PM

Revision Contents
Changeset List

Path

Size

support/

xhpast/

parser.y

50 lines

parser.yacc.cpp

820 lines

Diff 33714

View Options

support/xhpast/parser.y