Page MenuHomePhabricator
Differential D13969

Remove flex and bison debug flags
ClosedPublic
Actions

Authored by joshuaspence on Aug 23 2015, 2:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 11:16 PM
Unknown Object (File)
Thu, Apr 11, 8:42 AM
Unknown Object (File)
Fri, Apr 5, 1:00 AM
Unknown Object (File)
Thu, Apr 4, 2:36 PM
Unknown Object (File)
Tue, Mar 26, 4:53 AM
Unknown Object (File)
Tue, Mar 26, 4:17 AM
Unknown Object (File)
Tue, Mar 26, 4:17 AM
Unknown Object (File)
Tue, Mar 26, 4:17 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU76966a6f6b3e: Remove flex and bison debug flags
Summary

Remove --debug from flex and bison unless compiling with DEBUG defined.

Test Plan

Ran arc lint --everything --never-apply-patches --xprofile=profile.json in rP. Compared before and after.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33705.Aug 23 2015, 2:06 AM
joshuaspence retitled this revision from to Remove flex and bison debug flags.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 23 2015, 2:06 AM
Herald added a subscriber: epriestley. · View Herald Transcript
joshuaspence updated this revision to Diff 33706.Aug 23 2015, 2:12 AM
joshuaspence edited edge metadata.

Minor fix

joshuaspence edited the test plan for this revision. (Show Details)Aug 23 2015, 5:21 AM
joshuaspence added a reviewer: epriestley.
joshuaspence added a child revision: D13970: Enable bison warnings.
joshuaspence added a child revision: D13973: Remove some unused fields from yy_extra_type.Aug 23 2015, 5:35 AM
joshuaspence updated this revision to Diff 33712.Aug 23 2015, 7:21 AM

Bump XHPAST version

Herald added a subscriber: Korvin. · View Herald TranscriptAug 23 2015, 7:21 AM
epriestley accepted this revision.Aug 23 2015, 2:05 PM
epriestley edited edge metadata.
epriestley added inline comments.
support/xhpast/Makefile
3

CPPFLAGS also always gets -Wall I think?

This revision is now accepted and ready to land.Aug 23 2015, 2:05 PM
Closed by commit rPHU76966a6f6b3e: Remove flex and bison debug flags (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 23 2015, 9:01 PM
This revision was automatically updated to reflect the committed changes.
• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
bin/
2 lines
support/
xhpast/
20 lines
2 lines
2 lines
121 lines
355 lines
2 lines

Diff 33729

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...
View Options

support/xhpast/Makefile

Loading...
View Options

support/xhpast/parser.yacc.hpp

Loading...
View Options

support/xhpast/parser.yacc.cpp

Loading...
View Options

support/xhpast/scanner.lex.hpp

Loading...
View Options

support/xhpast/scanner.lex.cpp

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility