Pass the -Wall flag to bison to show warnings.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rPHU3cdc554b99cf: Enable bison warnings
Summary
Test Plan
Ran make -C support/xhpast parser and saw warnings.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
joshuaspence updated this object.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 23 2015, 2:19 AM2015-08-23 02:19:05 (UTC+0)
joshuaspence edited the test plan for this revision. (Show Details)Aug 23 2015, 3:52 AM2015-08-23 03:52:33 (UTC+0)
joshuaspence edited edge metadata.
joshuaspence added a parent revision: D13969: Remove flex and bison debug flags.Aug 23 2015, 5:22 AM2015-08-23 05:22:11 (UTC+0)
joshuaspence added a child revision: D13971: Fix bison "empty" warnings.Aug 23 2015, 7:44 AM2015-08-23 07:44:07 (UTC+0)
joshuaspence added a child revision: D13974: Fix bison warnings.Aug 23 2015, 8:12 AM2015-08-23 08:12:57 (UTC+0)
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 23 2015, 2:07 PM2015-08-23 14:07:11 (UTC+0)
Closed by commit rPHU3cdc554b99cf: Enable bison warnings (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 23 2015, 9:02 PM2015-08-23 21:02:45 (UTC+0)
This revision was automatically updated to reflect the committed changes.