Page MenuHomePhabricator

Add a linter rule for newlines after PHP open tags
ClosedPublic

Authored by joshuaspence on Jul 2 2015, 9:43 PM.
Tags
None
Referenced Files
F15396252: D13534.id33881.diff
Sun, Mar 16, 12:58 PM
F15390347: D13534.id33534.diff
Sat, Mar 15, 6:08 AM
F15335681: D13534.diff
Sat, Mar 8, 5:20 PM
F15299386: D13534.diff
Wed, Mar 5, 2:53 PM
Unknown Object (File)
Sat, Feb 22, 1:40 AM
Unknown Object (File)
Tue, Feb 18, 8:43 AM
Unknown Object (File)
Feb 11 2025, 9:36 PM
Unknown Object (File)
Feb 9 2025, 9:36 PM
Subscribers

Details

Summary

<?php\n\n... is much easier to read than <?php\n.... Depends on D13889 and D13890.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 7620
Build 8281: [Placeholder Plan] Wait for 30 Seconds
Build 8279: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Add a linter rule for newlines after PHP open tags.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/linter/xhpast/rules/ArcanistNewlineAfterOpenTagXHPASTLinterRule.php
29

I think this phrasing is maybe a little ambiguous, since it doesn't mean "a single newline character", but could be interpreted like that (i.e. "<?php\n1+1" has "a single newline character", but is not desired). Maybe "an empty line"?

This revision is now accepted and ready to land.Jul 2 2015, 9:48 PM

The fact that I needed to modify so many lint-test files was motivation for D14010.

This revision was automatically updated to reflect the committed changes.