Page MenuHomePhabricator
Differential D13534

Add a linter rule for newlines after PHP open tags
ClosedPublic
Actions

Authored by joshuaspence on Jul 2 2015, 9:43 PM.
Tags
None
Referenced Files
F15625828: D13534.id32714.diff
Sun, May 18, 11:25 AM
Unknown Object (File)
Thu, May 8, 2:16 AM
Unknown Object (File)
Wed, May 7, 7:56 PM
Unknown Object (File)
Tue, May 6, 8:12 PM
Unknown Object (File)
Mon, May 5, 7:58 PM
Unknown Object (File)
Fri, Apr 25, 12:03 AM
Unknown Object (File)
Wed, Apr 23, 4:41 PM
Unknown Object (File)
Wed, Apr 23, 9:18 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCa5304e472d18: Add a linter rule for newlines after PHP open tags
Summary

<?php\n\n... is much easier to read than <?php\n.... Depends on D13889 and D13890.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 7620
Build 8281: [Placeholder Plan] Wait for 30 Seconds
Build 8279: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 32714.Jul 2 2015, 9:43 PM
joshuaspence retitled this revision from to Add a linter rule for newlines after PHP open tags.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 2 2015, 9:43 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jul 2 2015, 9:48 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/linter/xhpast/rules/ArcanistNewlineAfterOpenTagXHPASTLinterRule.php
29

I think this phrasing is maybe a little ambiguous, since it doesn't mean "a single newline character", but could be interpreted like that (i.e. "<?php\n1+1" has "a single newline character", but is not desired). Maybe "an empty line"?

This revision is now accepted and ready to land.Jul 2 2015, 9:48 PM
joshuaspence mentioned this in D13889: Add a `getLineNumber()` method to `AASTToken`.Aug 13 2015, 9:57 PM
joshuaspence mentioned this in D13890: Don't eat whitespace after T_OPEN_TAG.Aug 13 2015, 10:20 PM
joshuaspence updated this object.Aug 13 2015, 10:21 PM
joshuaspence edited edge metadata.
joshuaspence added parent revisions: D13890: Don't eat whitespace after T_OPEN_TAG, D13889: Add a `getLineNumber()` method to `AASTToken`.
joshuaspence updated this revision to Diff 33534.Aug 13 2015, 10:35 PM

Various improvements

joshuaspence mentioned this in rPHU9c64e4ee00a6: Add a `getLineNumber()` method to `AASTToken`.Aug 27 2015, 12:08 PM
joshuaspence updated this revision to Diff 33867.Aug 30 2015, 12:49 AM

Fix failing tests

joshuaspence added a comment.Aug 30 2015, 11:51 AM

The fact that I needed to modify so many lint-test files was motivation for D14010.

joshuaspence mentioned this in D13949: Add Mocha TestEngine (not worth review / ready for upstream yet).Aug 30 2015, 12:36 PM
Closed by commit rARCa5304e472d18: Add a linter rule for newlines after PHP open tags (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 30 2015, 8:53 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in D14010: Test XHPAST linter rules in isolation.Aug 30 2015, 9:12 PM
joshuaspence mentioned this in rARC4d512c51d43c: Test XHPAST linter rules in isolation.Nov 18 2015, 9:57 PM

Revision Contents
Changeset List

Diff 33534

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/array-index.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/call-time-pass-by-reference.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/class-name-literal.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/constructor-parentheses.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/double-quote.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/duplicate-switch-case.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/elseif.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/empty-block-statement.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/empty-statement.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/formatted-string.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/global-variables.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/hash-comments.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/implicit-visibility.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/index-function.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/invalid-default-parameter.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/invalid-default-paramter.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/invalid-modifiers.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/language-construct-parentheses.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/lowercase-functions.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/modifier-ordering.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/naming-conventions.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/newline-after-open-tag.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/no-segfault-on-abstract.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/no-segfault-on-exit.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/php54-incompat.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/semicolon-spacing.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/space-after-control-keywords.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/space-around-more-operators.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/space-around-operators.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/surprising-constructors.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/unary-prefix-expression-spacing.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/unnecessary-final-modifier.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/unreasonably-deep-nesting.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/variable-variables.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/wrong-concat-operator.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistNewlineAfterOpenTagXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility