Page MenuHomePhabricator
Differential D13859

Improve linter rules for array formatting
ClosedPublic
Actions

Authored by joshuaspence on Aug 11 2015, 11:42 AM.
Tags
None
Referenced Files
F13920639: D13859.id33486.diff
Thu, Oct 10, 7:17 PM
F13920306: D13859.diff
Thu, Oct 10, 5:20 PM
Unknown Object (File)
Mon, Sep 30, 9:05 PM
Unknown Object (File)
Tue, Sep 24, 2:26 PM
Unknown Object (File)
Sat, Sep 21, 10:21 AM
Unknown Object (File)
Sep 5 2024, 9:30 AM
Unknown Object (File)
Sep 4 2024, 1:54 PM
Unknown Object (File)
Aug 24 2024, 7:35 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC31a49196801a: Improve linter rules for array formatting
Summary

Modify ArcanistParenthesesSpacingXHPASTLinterRule and ArcanistCallParenthesesXHPASTLinterRule to apply to array() and list() as well. Depends on D13858.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33475.Aug 11 2015, 11:42 AM
joshuaspence retitled this revision from to Improve linter rules for array formatting.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D13858: Include parentheses in n_ARRAY_VALUE_LIST node.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 11 2015, 11:42 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 11 2015, 12:28 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2015, 12:28 PM
Closed by commit rARC31a49196801a: Improve linter rules for array formatting (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 11 2015, 12:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33486

View Options

src/lint/linter/__tests__/phlxhp/array-formatting.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistCallParenthesesXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistParenthesesSpacingXHPASTLinterRule.php

Loading...
View Options

src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php

Loading...
Phabricator · Built by Phacility