Page MenuHomePhabricator

Include parentheses in n_ARRAY_VALUE_LIST node
ClosedPublic

Authored by joshuaspence on Aug 11 2015, 10:54 AM.
Tags
None
Referenced Files
F15418902: D13858.id33482.diff
Fri, Mar 21, 2:15 AM
F15408686: D13858.id33484.diff
Wed, Mar 19, 12:49 AM
F15400059: D13858.id33485.diff
Mon, Mar 17, 9:25 AM
F15380573: D13858.id33473.diff
Fri, Mar 14, 3:40 AM
F15338365: D13858.id33474.diff
Sun, Mar 9, 10:39 AM
F15312317: D13858.id33484.diff
Thu, Mar 6, 2:53 PM
F15312316: D13858.id33482.diff
Thu, Mar 6, 2:53 PM
F15312314: D13858.id33473.diff
Thu, Mar 6, 2:53 PM
Subscribers

Details

Summary

Currently parsing array(1, 2, 3) results in a n_ARRAY_VALUE_LIST with a concrete string of 1, 2, 3. Compare this to list($x, $y) which results in a n_ASSIGNMENT_LIST with a concrete string of ($x, $y).

Test Plan

See next diff.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Include parentheses in n_ARRAY_VALUE_LIST node.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.

Fix for list($i, list($j, $k)) = y()

epriestley edited edge metadata.

Also bump version?

This revision is now accepted and ready to land.Aug 11 2015, 12:28 PM
This revision was automatically updated to reflect the committed changes.