Page MenuHomePhabricator

Include parentheses in n_ARRAY_VALUE_LIST node
ClosedPublic

Authored by joshuaspence on Aug 11 2015, 10:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 4:48 AM
Unknown Object (File)
Thu, Jan 30, 4:48 AM
Unknown Object (File)
Wed, Jan 29, 7:32 PM
Unknown Object (File)
Wed, Jan 29, 4:25 PM
Unknown Object (File)
Tue, Jan 28, 3:09 AM
Unknown Object (File)
Sun, Jan 26, 2:35 PM
Unknown Object (File)
Sun, Jan 26, 2:35 PM
Unknown Object (File)
Sun, Jan 26, 2:35 PM
Subscribers

Details

Summary

Currently parsing array(1, 2, 3) results in a n_ARRAY_VALUE_LIST with a concrete string of 1, 2, 3. Compare this to list($x, $y) which results in a n_ASSIGNMENT_LIST with a concrete string of ($x, $y).

Test Plan

See next diff.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Include parentheses in n_ARRAY_VALUE_LIST node.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.

Fix for list($i, list($j, $k)) = y()

epriestley edited edge metadata.

Also bump version?

This revision is now accepted and ready to land.Aug 11 2015, 12:28 PM
This revision was automatically updated to reflect the committed changes.