Paths

Table of Contentst

Differential D13859

Improve linter rules for array formatting
ClosedPublic
Actions

Authored by joshuaspence on Aug 11 2015, 11:42 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 21, 2:30 PM

	Unknown Object (File)
	Tue, Dec 17, 9:08 PM

	Unknown Object (File)
	Tue, Dec 17, 9:07 PM

	Unknown Object (File)
	Tue, Dec 17, 8:07 PM

	Unknown Object (File)
	Tue, Dec 17, 7:11 PM

	Unknown Object (File)
	Sun, Dec 8, 12:19 AM

	Unknown Object (File)
	Mon, Dec 2, 8:41 PM

	Unknown Object (File)
	Nov 27 2024, 10:04 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC31a49196801a: Improve linter rules for array formatting

Summary

Modify ArcanistParenthesesSpacingXHPASTLinterRule and ArcanistCallParenthesesXHPASTLinterRule to apply to array() and list() as well. Depends on D13858.

Test Plan

Added unit tests.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 7583
Build 8206: [Placeholder Plan] Wait for 30 Seconds
Build 8205: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	2,576 ms	ArcanistJSHintLinterTestCase::Unknown Unit Message ("")
	3,056 ms	ArcanistPhutilXHPASTLinterTestCase::Unknown Unit Message ("")
	140 ms	PhpunitTestEngineTestCase::Unknown Unit Message ("")
	180 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	2,103 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
		View Full Test Results (3 Failed · 54 Passed · 7 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 33475.Aug 11 2015, 11:42 AM

joshuaspence retitled this revision from to Improve linter rules for array formatting.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D13858: Include parentheses in n_ARRAY_VALUE_LIST node.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 11 2015, 11:42 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Aug 11 2015, 12:28 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 11 2015, 12:28 PM

Closed by commit rARC31a49196801a: Improve linter rules for array formatting (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 11 2015, 12:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

lint/

linter/

__tests__/

phlxhp/

array-formatting.lint-test

16 lines

-

-

xhpast/

rules/

ArcanistCallParenthesesXHPASTLinterRule.php

42 lines

94%

Loading...

ArcanistParenthesesSpacingXHPASTLinterRule.php

4 lines

95%

Loading...

unit/

engine/

ArcanistConfigurationDrivenUnitTestEngine.php

19 lines

0%

Loading...

Diff 33475

src/lint/linter/tests/phlxhp/array-formatting.lint-test

Loading...

src/lint/linter/xhpast/rules/ArcanistCallParenthesesXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistParenthesesSpacingXHPASTLinterRule.php

Loading...

src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php

Loading...