Page MenuHomePhabricator
Differential D13550

Symbol Search: Allow ctrl-click with no hover
ClosedPublic
Actions

Authored by avivey on Jul 4 2015, 3:19 AM.
Tags
None
Referenced Files
F18048664: D13550.id.diff
Sun, Aug 3, 1:41 PM
F17927843: D13550.id32737.diff
Wed, Jul 30, 3:17 PM
F17836854: D13550.id.diff
Sat, Jul 26, 4:37 PM
F17820881: D13550.diff
Sat, Jul 26, 2:20 AM
Unknown Object (File)
Jun 7 2025, 1:03 AM
Unknown Object (File)
May 30 2025, 10:59 AM
Unknown Object (File)
May 29 2025, 3:37 PM
Unknown Object (File)
May 29 2025, 12:58 PM
View All Files
Subscribers
epriestley
gena2x
joshuaspence
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8710: Symbol lookup requires ctrl-hover-and-click, instead of just ctrl-click
Commits
Restricted Diffusion Commit
rP328d336c8bb3: Symbol Search: Allow ctrl-click with no hover
Summary

Fix T8710. I had hopes of doing something cleaver with highlighted (Like trying to understand foo.bar when clicking bar, but I obviously didn't do it.

Test Plan

ctrl-click.

Diff Detail

Repository
rP Phabricator
Branch
ctrl-click
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7141
Build 7330: [Placeholder Plan] Wait for 30 Seconds
Build 7329: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 32737.Jul 4 2015, 3:19 AM
avivey retitled this revision from to Symbol Search: Allow ctrl-click with no hover.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added reviewers: epriestley, joshuaspence.
avivey added a task: T8710: Symbol lookup requires ctrl-hover-and-click, instead of just ctrl-click.
avivey added a subscriber: gena2x.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 4 2015, 3:19 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
avivey updated this object.Jul 4 2015, 3:20 AM
avivey edited edge metadata.
avivey updated this revision to Diff 32739.Jul 4 2015, 4:21 AM

celerify

joshuaspence resigned from this revision.Jul 7 2015, 1:14 PM
joshuaspence removed a reviewer: joshuaspence.

I don't know enough about Phabricator JavaScript to comment here.

joshuaspence added a subscriber: joshuaspence.Jul 19 2015, 12:46 AM
avivey mentioned this in Z1336: General Chat.Aug 27 2015, 2:31 AM
epriestley accepted this revision.Aug 27 2015, 11:17 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 27 2015, 11:17 AM
Closed by commit rP328d336c8bb3: Symbol Search: Allow ctrl-click with no hover (authored by avivey, committed by epriestley). · Explain WhyAug 27 2015, 11:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
18 lines
webroot/
rsrc/
js/
application/
repository/
2 lines

Diff 32739

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/repository/repository-crossreference.js

Loading...
Phabricator · Built by Phacility