Paths

Table of Contentst

Differential D13534

Add a linter rule for newlines after PHP open tags
ClosedPublic
Actions

Authored by joshuaspence on Jul 2 2015, 9:43 PM.

Tags

None

Referenced Files

	F15424354: D13534.diff
	Sat, Mar 22, 9:43 PM

	F15423701: D13534.id33867.diff
	Sat, Mar 22, 4:47 PM

	F15423185: D13534.id33881.diff
	Sat, Mar 22, 1:45 PM

	F15422485: D13534.id32714.diff
	Sat, Mar 22, 8:41 AM

	F15420960: D13534.id.diff
	Fri, Mar 21, 7:33 PM

	F15420887: D13534.id.diff
	Fri, Mar 21, 6:41 PM

	F15419940: D13534.id33534.diff
	Fri, Mar 21, 10:00 AM

	F15416412: D13534.diff
	Thu, Mar 20, 10:56 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCa5304e472d18: Add a linter rule for newlines after PHP open tags

Summary

<?php\n\n... is much easier to read than <?php\n.... Depends on D13889 and D13890.

Test Plan

Added unit tests.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 7122
Build 7296: [Placeholder Plan] Wait for 30 Seconds
Build 7295: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1,998 ms	ArcanistJSHintLinterTestCase::Unknown Unit Message ("")
	14,273 ms	ArcanistXHPASTLinterTestCase::Unknown Unit Message ("")
	981 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	177 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	208 ms	ArcanistChmodLinterTestCase::Unknown Unit Message ("")
		View Full Test Results (2 Failed · 49 Passed · 7 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 32714.Jul 2 2015, 9:43 PM

joshuaspence retitled this revision from to Add a linter rule for newlines after PHP open tags.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 2 2015, 9:43 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jul 2 2015, 9:48 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/lint/linter/xhpast/rules/ArcanistNewlineAfterOpenTagXHPASTLinterRule.php
28	I think this phrasing is maybe a little ambiguous, since it doesn't mean "a single newline character", but could be interpreted like that (i.e. "<?php\n1+1" has "a single newline character", but is not desired). Maybe "an empty line"?

This revision is now accepted and ready to land.Jul 2 2015, 9:48 PM

joshuaspence mentioned this in D13889: Add a `getLineNumber()` method to `AASTToken`.Aug 13 2015, 9:57 PM

joshuaspence mentioned this in D13890: Don't eat whitespace after T_OPEN_TAG.Aug 13 2015, 10:20 PM

joshuaspence updated this object.Aug 13 2015, 10:21 PM

joshuaspence edited edge metadata.

joshuaspence added parent revisions: D13890: Don't eat whitespace after T_OPEN_TAG, D13889: Add a `getLineNumber()` method to `AASTToken`.

Various improvements

joshuaspence mentioned this in rPHU9c64e4ee00a6: Add a `getLineNumber()` method to `AASTToken`.Aug 27 2015, 12:08 PM

Fix failing tests

The fact that I needed to modify so many lint-test files was motivation for D14010.

joshuaspence mentioned this in D13949: Add Mocha TestEngine (not worth review / ready for upstream yet).Aug 30 2015, 12:36 PM

Closed by commit rARCa5304e472d18: Add a linter rule for newlines after PHP open tags (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 30 2015, 8:53 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D14010: Test XHPAST linter rules in isolation.Aug 30 2015, 9:12 PM

joshuaspence mentioned this in rARC4d512c51d43c: Test XHPAST linter rules in isolation.Nov 18 2015, 9:57 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

__phutil_library_map__.php

2 lines

-

-

lint/

linter/

__tests__/

xhpast/

array-index.lint-test

10 lines

-

-

call-time-pass-by-reference.lint-test

21 lines

-

-

class-name-literal.lint-test

8 lines

-

-

constructor-parentheses.lint-test

6 lines

-

-

double-quote.lint-test

4 lines

-

-

duplicate-switch-case.lint-test

5 lines

-

-

elseif.lint-test

4 lines

-

-

empty-block-statement.lint-test

4 lines

-

-

empty-statement.lint-test

8 lines

-

-

formatted-string.lint-test

9 lines

-

-

hash-comments.lint-test

14 lines

-

-

implicit-visibility.lint-test

8 lines

-

-

index-function.lint-test

3 lines

-

-

	invalid-default-parameter.lint-test
	invalid-default-paramter.lint-test

7 lines

-

-

invalid-default-paramter.lint-test

-

-

invalid-modifiers.lint-test

11 lines

-

-

language-construct-parentheses.lint-test

22 lines

-

-

lowercase-functions.lint-test

4 lines

-

-

modifier-ordering.lint-test

10 lines

-

-

naming-conventions.lint-test

31 lines

-

-

newline-after-open-tag.lint-test

10 lines

-

-

no-segfault-on-abstract.lint-test

1 line

-

-

no-segfault-on-exit.lint-test

1 line

-

-

php54-incompat.lint-test

9 lines

-

-

semicolon-spacing.lint-test

4 lines

-

-

space-after-control-keywords.lint-test

18 lines

-

-

space-around-more-operators.lint-test

18 lines

-

-

space-around-operators.lint-test

24 lines

-

-

surprising-constructors.lint-test

5 lines

-

-

unnecessary-final-modifier.lint-test

5 lines

-

-

unreasonably-deep-nesting.lint-test

2 lines

-

-

variable-variables.lint-test

3 lines

-

-

wrong-concat-operator.lint-test

3 lines

-

-

xhpast/

rules/

ArcanistNewlineAfterOpenTagXHPASTLinterRule.php

33 lines

100%

Loading...

Diff 32714

src/__phutil_library_map__.php

Loading...

src/lint/linter/tests/xhpast/array-index.lint-test

Loading...

src/lint/linter/tests/xhpast/call-time-pass-by-reference.lint-test

Loading...

src/lint/linter/tests/xhpast/class-name-literal.lint-test

Loading...

src/lint/linter/tests/xhpast/constructor-parentheses.lint-test

Loading...

src/lint/linter/tests/xhpast/double-quote.lint-test

Loading...

src/lint/linter/tests/xhpast/duplicate-switch-case.lint-test

Loading...

src/lint/linter/tests/xhpast/elseif.lint-test

Loading...

src/lint/linter/tests/xhpast/empty-block-statement.lint-test

Loading...

src/lint/linter/tests/xhpast/empty-statement.lint-test

Loading...

src/lint/linter/tests/xhpast/formatted-string.lint-test

Loading...

src/lint/linter/tests/xhpast/hash-comments.lint-test

Loading...

src/lint/linter/tests/xhpast/implicit-visibility.lint-test

Loading...

src/lint/linter/tests/xhpast/index-function.lint-test

Loading...

src/lint/linter/tests/xhpast/invalid-default-parameter.lint-test

Loading...

src/lint/linter/tests/xhpast/invalid-default-paramter.lint-test

Loading...

src/lint/linter/tests/xhpast/invalid-modifiers.lint-test

Loading...

src/lint/linter/tests/xhpast/language-construct-parentheses.lint-test

Loading...

src/lint/linter/tests/xhpast/lowercase-functions.lint-test

Loading...

src/lint/linter/tests/xhpast/modifier-ordering.lint-test

Loading...

src/lint/linter/tests/xhpast/naming-conventions.lint-test

Loading...

src/lint/linter/tests/xhpast/newline-after-open-tag.lint-test

Loading...

src/lint/linter/tests/xhpast/no-segfault-on-abstract.lint-test

Loading...

src/lint/linter/tests/xhpast/no-segfault-on-exit.lint-test

Loading...

src/lint/linter/tests/xhpast/php54-incompat.lint-test

Loading...

src/lint/linter/tests/xhpast/semicolon-spacing.lint-test

Loading...

src/lint/linter/tests/xhpast/space-after-control-keywords.lint-test

Loading...

src/lint/linter/tests/xhpast/space-around-more-operators.lint-test

Loading...

src/lint/linter/tests/xhpast/space-around-operators.lint-test

Loading...

src/lint/linter/tests/xhpast/surprising-constructors.lint-test

Loading...

src/lint/linter/tests/xhpast/unnecessary-final-modifier.lint-test

Loading...

src/lint/linter/tests/xhpast/unreasonably-deep-nesting.lint-test

Loading...

src/lint/linter/tests/xhpast/variable-variables.lint-test

Loading...

src/lint/linter/tests/xhpast/wrong-concat-operator.lint-test

Loading...

src/lint/linter/xhpast/rules/ArcanistNewlineAfterOpenTagXHPASTLinterRule.php

Loading...