If I understand correctly, all classes should extend from Phobject?
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARCac8367a884ff: Add a linter rule for extending Phobject
This needs some further work
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- master
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 6726 Build 6748: [Placeholder Plan] Wait for 30 Seconds
| Time | Test | |
|---|---|---|
| 19 ms | ArcanistPuppetLintLinterTestCase::testLinter | |
| 7 ms | ArcanistPuppetLintLinterTestCase::testVersion | |
| 894 ms | ArcanistCSSLintLinterTestCase::testLinter | |
| 244 ms | ArcanistCSSLintLinterTestCase::testVersion | |
| 24 ms | ArcanistChmodLinterTestCase::testLinter | |
| View Full Test Results (2 Failed · 41 Passed · 9 Skipped) |
Event Timeline
Comment Actions
Seems reasonable. Couple of inlines.
| src/lint/linter/ArcanistPhutilXHPASTLinter.php | ||
|---|---|---|
| 317–318 | Do we need a check for Phobject itself here? I'd guess this might raise a silly "phobject must extend phobject" warning. | |
| 322 | Maybe more clear as "...extend from Phobject or some other object.", to make it clear that "class B extends A {" is fine, just not "class B {". | |
| src/lint/linter/ArcanistPhutilXHPASTLinter.php | ||
|---|---|---|
| 327 | Maybe "...from some other class.", vs "other object." | |