Paths

Table of Contentst

Differential D13275

Add a linter rule for extending Phobject
ClosedPublic
Actions

Authored by joshuaspence on Jun 13 2015, 11:29 AM.

Tags

None

Referenced Files

	F14760551: D13275.diff
	Wed, Jan 22, 6:46 PM

	Unknown Object (File)
	Tue, Jan 21, 3:58 PM

	Unknown Object (File)
	Tue, Jan 21, 3:39 PM

	Unknown Object (File)
	Fri, Jan 17, 5:26 PM

	Unknown Object (File)
	Mon, Jan 13, 7:47 PM

	Unknown Object (File)
	Tue, Jan 7, 2:04 PM

	Unknown Object (File)
	Dec 19 2024, 12:17 AM

	Unknown Object (File)
	Dec 12 2024, 6:48 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCac8367a884ff: Add a linter rule for extending Phobject

Summary

If I understand correctly, all classes should extend from Phobject?

Test Plan

This needs some further work

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6738
Build 6760: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 32074.Jun 13 2015, 11:29 AM

joshuaspence retitled this revision from to Add a linter rule for extending Phobject.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 13 2015, 11:29 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Seems reasonable. Couple of inlines.

src/lint/linter/ArcanistPhutilXHPASTLinter.php
317–318	Do we need a check for `Phobject` itself here? I'd guess this might raise a silly "phobject must extend phobject" warning.
322	Maybe more clear as "...extend from Phobject or some other object.", to make it clear that "class B extends A {" is fine, just not "class B {".

This revision now requires changes to proceed.Jun 13 2015, 3:44 PM

Add a check for Phobject

Oops

epriestley accepted this revision.Jun 14 2015, 1:55 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/lint/linter/ArcanistPhutilXHPASTLinter.php
327	Maybe "...from some other class.", vs "other object."

This revision is now accepted and ready to land.Jun 14 2015, 1:55 PM

joshuaspence added inline comments.Jun 14 2015, 9:31 PM

src/lint/linter/ArcanistPhutilXHPASTLinter.php
315	This isn't quite sufficient in the general case, see T8534.

Closed by commit rARCac8367a884ff: Add a linter rule for extending Phobject (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 15 2015, 5:45 AM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D13283: Extend from Phobject.Jun 15 2015, 5:45 AM

joshuaspence mentioned this in D13281: Extend from Phobject.

joshuaspence mentioned this in D13280: Extend from Phobject.

joshuaspence mentioned this in rARC956bfa701c36: Extend from Phobject.Jun 15 2015, 5:50 AM

joshuaspence mentioned this in rPHU3ff84448a916: Extend from Phobject.Jun 15 2015, 5:52 AM

joshuaspence mentioned this in rPb6d745b66687: Extend from Phobject.Jun 15 2015, 8:07 AM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistPhutilXHPASTLinter.php

46 lines

__tests__/

phlxhp/

extends-phobject.lint-test

7 lines

ragged-classtree-edges.lint-test

8 lines

Diff 32097

src/lint/linter/ArcanistPhutilXHPASTLinter.php

Loading...

src/lint/linter/tests/phlxhp/extends-phobject.lint-test

Loading...

src/lint/linter/tests/phlxhp/ragged-classtree-edges.lint-test

Loading...