Page MenuHomePhabricator
Differential D12308

Further improvements to array comma linter rule
ClosedPublic
Actions

Authored by joshuaspence on Apr 6 2015, 9:56 PM.
Tags
None
Referenced Files
F15506114: D12308.id31149.diff
Tue, Apr 15, 8:45 AM
F15456664: D12308.diff
Sun, Mar 30, 11:09 AM
F15443205: D12308.id31149.diff
Thu, Mar 27, 3:01 AM
F15436465: D12308.id30962.diff
Tue, Mar 25, 2:24 PM
F15435684: D12308.id.diff
Tue, Mar 25, 9:43 AM
F15434932: D12308.id29565.diff
Tue, Mar 25, 6:07 AM
F15430560: D12308.diff
Mon, Mar 24, 8:11 AM
F15385129: D12308.id29565.diff
Mar 14 2025, 9:47 PM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC993166fa497e: Further improvements to array comma linter rule
Summary

Improve the ArcanistXHPASTLinter::LINT_ARRAY_SEPARATOR rule to be able to autofix the following code:

array(
  1,
  2,
  3, /* comment */ );
Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/lint/linter/__tests__/xhpast/array-comma.lint-test:73TXT6Trailing Whitespace
Auto-Fixsrc/lint/linter/__tests__/xhpast/array-comma.lint-test:78TXT6Trailing Whitespace
Unit
Tests Passed
Build Status
Buildable 6027
Build 6047: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29565.Apr 6 2015, 9:56 PM
joshuaspence retitled this revision from to Further improvements to array comma linter rule.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 6 2015, 9:56 PM
Herald added a subscriber: epriestley. · View Herald Transcript
• nagym718 added a task: T5042: Futures()->limit(X) does not ensure that X number of tasks are running after the first set of tasks.Apr 7 2015, 8:03 AM
epriestley removed a task: T5042: Futures()->limit(X) does not ensure that X number of tasks are running after the first set of tasks.Apr 7 2015, 12:25 PM
joshuaspence updated this revision to Diff 30962.May 16 2015, 1:34 AM
joshuaspence edited edge metadata.

Works now

joshuaspence updated this object.May 19 2015, 1:24 PM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley accepted this revision.May 19 2015, 3:14 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 3:14 PM
Closed by commit rARC993166fa497e: Further improvements to array comma linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 9:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
2 lines
src/
lint/
linter/
48 lines
__tests__/
xhpast/
12 lines

Diff 30962

View Options

.editorconfig

Loading...
View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/array-comma.lint-test

Loading...
Phabricator · Built by Phacility