Page MenuHomePhabricator

Further improvements to array comma linter rule
ClosedPublic

Authored by joshuaspence on Apr 6 2015, 9:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 9:51 AM
Unknown Object (File)
Fri, Apr 5, 5:36 AM
Unknown Object (File)
Fri, Apr 5, 5:35 AM
Unknown Object (File)
Fri, Apr 5, 5:35 AM
Unknown Object (File)
Fri, Apr 5, 5:25 AM
Unknown Object (File)
Fri, Apr 5, 5:22 AM
Unknown Object (File)
Mon, Apr 1, 7:29 AM
Unknown Object (File)
Sun, Mar 31, 7:35 PM
Subscribers

Details

Summary

Improve the ArcanistXHPASTLinter::LINT_ARRAY_SEPARATOR rule to be able to autofix the following code:

array(
  1,
  2,
  3, /* comment */ );
Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/lint/linter/__tests__/xhpast/array-comma.lint-test:73TXT6Trailing Whitespace
Auto-Fixsrc/lint/linter/__tests__/xhpast/array-comma.lint-test:78TXT6Trailing Whitespace
Unit
Tests Passed
Build Status
Buildable 6027
Build 6047: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Further improvements to array comma linter rule.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 3:14 PM
This revision was automatically updated to reflect the committed changes.