Page MenuHomePhabricator

Further improvements to array comma linter rule
ClosedPublic

Authored by joshuaspence on Apr 6 2015, 9:56 PM.
Tags
None
Referenced Files
F13238999: D12308.diff
Tue, May 21, 11:16 PM
F13232615: D12308.diff
Tue, May 21, 1:24 AM
F13198745: D12308.id.diff
Mon, May 13, 9:31 AM
F13193660: D12308.id30962.diff
Sun, May 12, 4:30 PM
F13192123: D12308.id29565.diff
Sun, May 12, 5:38 AM
F13189431: D12308.diff
Sat, May 11, 5:56 AM
F13183354: D12308.id31149.diff
Fri, May 10, 8:32 AM
Unknown Object (File)
Wed, May 1, 12:14 AM
Subscribers

Details

Summary

Improve the ArcanistXHPASTLinter::LINT_ARRAY_SEPARATOR rule to be able to autofix the following code:

array(
  1,
  2,
  3, /* comment */ );
Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
No Lint Coverage
Unit
Test Failures
Build Status
Buildable 5167
Build 5185: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
8,860 msArcanistXHPASTLinterTestCase::testLinter
816 msArcanistCSSLintLinterTestCase::testLinter
119 msArcanistCSSLintLinterTestCase::testVersion
126 msArcanistChmodLinterTestCase::testLinter
217 msArcanistClosureLinterTestCase::testLinter
View Full Test Results (1 Failed · 46 Passed · 6 Skipped)

Event Timeline

joshuaspence retitled this revision from to Further improvements to array comma linter rule.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 3:14 PM
This revision was automatically updated to reflect the committed changes.